Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm b/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
index b22b6cc8ed4c7a5372b01ea0cac893897ed2fbcb..84855567eb09a3bf0c0b30e0c8660b6c10388d71 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
@@ -4,7 +4,7 @@
#import "ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "components/bookmarks/browser/base_bookmark_model_observer.h"
#include "components/bookmarks/browser/bookmark_model.h"
@@ -15,9 +15,7 @@
using bookmarks::BookmarkNode;
-@interface BookmarkHomeViewController () {
- base::mac::ObjCPropertyReleaser _propertyReleaser_BookmarkHomeViewController;
-}
+@interface BookmarkHomeViewController ()
// Redefined to be readwrite.
@property(nonatomic, retain, readwrite) NSMutableArray* editIndexPaths;
@@ -42,9 +40,6 @@ defaultMoveFolderFromBookmarks:(const std::set<const BookmarkNode*>&)bookmarks
DCHECK(browserState);
self = [super initWithNibName:nil bundle:nil];
if (self) {
- _propertyReleaser_BookmarkHomeViewController.Init(
- self, [BookmarkHomeViewController class]);
-
_browserState = browserState->GetOriginalChromeBrowserState();
_loader = loader;
@@ -56,6 +51,11 @@ defaultMoveFolderFromBookmarks:(const std::set<const BookmarkNode*>&)bookmarks
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (void)loadView {
CGRect frame = [[UIScreen mainScreen] bounds];
self.view =

Powered by Google App Engine
This is Rietveld 408576698