Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm b/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm
index 6c0e9ce2b9bc59b20e444f5c303899b441a1bb74..a6d2730cc465857da20ff13364ef8b42154de101 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm
@@ -9,7 +9,7 @@
#include "base/ios/block_types.h"
#import "base/ios/weak_nsobject.h"
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/metrics/user_metrics.h"
#include "base/metrics/user_metrics_action.h"
@@ -95,9 +95,6 @@ const CGFloat kNavigationBarTopMargin = 8.0;
// DO NOT modify these two ivars directly.
std::set<const BookmarkNode*> _editNodes;
std::vector<const BookmarkNode*> _editNodesOrdered;
-
- base::mac::ObjCPropertyReleaser
- _propertyReleaser_BookmarkHomeTabletNTPController;
}
@property(nonatomic, retain) BookmarkPanelView* panelView;
@@ -311,9 +308,6 @@ const CGFloat kNavigationBarTopMargin = 8.0;
DCHECK(browserState);
_browserState = browserState->GetOriginalChromeBrowserState();
_loader = loader;
- _propertyReleaser_BookmarkHomeTabletNTPController.Init(
- self, [BookmarkHomeTabletNTPController class]);
-
_bookmarks = ios::BookmarkModelFactory::GetForBrowserState(_browserState);
_bridge.reset(new bookmarks::BookmarkModelBridge(self, _bookmarks));
_editIndexPaths = [[NSMutableArray alloc] init];
@@ -337,6 +331,7 @@ const CGFloat kNavigationBarTopMargin = 8.0;
_editViewController.delegate = nil;
_folderSelector.delegate = nil;
+ base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698