Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: weak -> assign Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm b/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm
index ab58a753423e5d4d0159922599f8129d51781252..c538cd7ecd10f3838f1e6a8731b971bbc3a5ab7b 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm
@@ -8,7 +8,7 @@
#import "base/ios/weak_nsobject.h"
#include "base/logging.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/metrics/user_metrics.h"
#include "base/metrics/user_metrics_action.h"
@@ -60,8 +60,6 @@ const CGFloat kBookmarkMenuWidth = 264;
BookmarkPromoControllerDelegate> {
// Bridge to register for bookmark changes.
std::unique_ptr<bookmarks::BookmarkModelBridge> _bridge;
- base::mac::ObjCPropertyReleaser
- _propertyReleaser_BookmarkHomeHandsetViewController;
}
// This views holds the primary content of this view controller. At any point in
@@ -243,9 +241,6 @@ const CGFloat kBookmarkMenuWidth = 264;
browserState:(ios::ChromeBrowserState*)browserState {
self = [super initWithLoader:loader browserState:browserState];
if (self) {
- _propertyReleaser_BookmarkHomeHandsetViewController.Init(
- self, [BookmarkHomeHandsetViewController class]);
-
_bridge.reset(new bookmarks::BookmarkModelBridge(self, self.bookmarks));
// It is important to initialize the promo controller with the browser state
// passed in, as it could be incognito.
@@ -266,6 +261,7 @@ const CGFloat kBookmarkMenuWidth = 264;
_folderSelector.delegate = nil;
_panelView.delegate = nil;
+ base::mac::ReleaseProperties(self);
[super dealloc];
}

Powered by Google App Engine
This is Rietveld 408576698