Replace ObjCPropertyReleaser with ReleaseProperties() project-wide.

ios/chrome/browser/payments/payment_request_coordinator.mm

Index: ios/chrome/browser/payments/payment_request_coordinator.mm
diff --git a/ios/chrome/browser/payments/payment_request_coordinator.mm b/ios/chrome/browser/payments/payment_request_coordinator.mm
index 62f04ffb9f875d36d633c4357146da07814e26c7..c85e740ee40b623311d9f5fc909d2aed63f61bf2 100644
--- a/ios/chrome/browser/payments/payment_request_coordinator.mm
+++ b/ios/chrome/browser/payments/payment_request_coordinator.mm
@@ -8,7 +8,7 @@
 #include <vector>
 
 #import "base/ios/weak_nsobject.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
@@ -32,8 +32,6 @@
       _shippingOptionSelectionCoordinator;
   base::scoped_nsobject<PaymentMethodSelectionCoordinator>
       _methodSelectionCoordinator;
-
-  base::mac::ObjCPropertyReleaser _propertyReleaser_PaymentRequestCoordinator;
 }
 
 @end
@@ -48,12 +46,15 @@
 - (instancetype)initWithBaseViewController:
     (UIViewController*)baseViewController {
   if ((self = [super initWithBaseViewController:baseViewController])) {

[sdefresne, 2017/02/14 16:34:26]

Looks like this is now just calling super -initWithBaseViewController:, so maybe
remove?

[Sidney San Martín, 2017/02/14 21:38:15]

Done, thanks. When I initially tried to remove this, I got a diagnostic from
-Wobjc-designated-initializers. I could've sworn I saw other examples of empty
init overrides in the iOS codebase, so I left it. However, I now think that's
just because it's redeclared in payment_request_coordinator.h. I deleted it, but
I'm not sure if the comment in the .h was worth preserving. What do you think?

-    _propertyReleaser_PaymentRequestCoordinator.Init(
-        self, [PaymentRequestCoordinator class]);
   }
   return self;
 }
 
+- (void)dealloc {
+  base::mac::ReleaseProperties(self);
+  [super dealloc];
+}
+
 - (id<PaymentRequestCoordinatorDelegate>)delegate {
   return _delegate.get();
 }