Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: ios/chrome/browser/payments/payment_request_view_controller.mm

Issue 2610923005: Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Yank unrelated changes. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/payments/payment_request_view_controller.mm
diff --git a/ios/chrome/browser/payments/payment_request_view_controller.mm b/ios/chrome/browser/payments/payment_request_view_controller.mm
index 3e02a17c7d15e8fd1fb56579242caf5158044115..ef42e5a76464c8b95ca78e2419ee339de439574f 100644
--- a/ios/chrome/browser/payments/payment_request_view_controller.mm
+++ b/ios/chrome/browser/payments/payment_request_view_controller.mm
@@ -6,7 +6,7 @@
#import "base/ios/weak_nsobject.h"
#include "base/mac/foundation_util.h"
-#include "base/mac/objc_property_releaser.h"
+#include "base/mac/objc_release_properties.h"
#include "base/mac/scoped_nsobject.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
@@ -84,9 +84,6 @@ typedef NS_ENUM(NSInteger, ItemType) {
PriceItem* _paymentSummaryItem;
ShippingAddressItem* _selectedShippingAddressItem;
CollectionViewTextItem* _selectedShippingOptionItem;
-
- base::mac::ObjCPropertyReleaser
- _propertyReleaser_PaymentRequestViewController;
}
// Called when the user presses the cancel button.
@@ -106,9 +103,6 @@ typedef NS_ENUM(NSInteger, ItemType) {
- (instancetype)initWithPaymentRequest:(PaymentRequest*)paymentRequest {
DCHECK(paymentRequest);
if ((self = [super initWithStyle:CollectionViewControllerStyleAppBar])) {
- _propertyReleaser_PaymentRequestViewController.Init(
- self, [PaymentRequestViewController class]);
-
[self setTitle:l10n_util::GetNSString(IDS_IOS_PAYMENT_REQUEST_TITLE)];
// Set up left (cancel) button.
@@ -170,6 +164,11 @@ typedef NS_ENUM(NSInteger, ItemType) {
return self;
}
+- (void)dealloc {
+ base::mac::ReleaseProperties(self);
+ [super dealloc];
+}
+
- (id<PaymentRequestViewControllerDelegate>)delegate {
return _delegate.get();
}

Powered by Google App Engine
This is Rietveld 408576698