Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2610823003: PreParsing inner funcs: declare arrow function parameters. (Closed)

Created:
3 years, 11 months ago by marja
Modified:
3 years, 11 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PreParsing inner funcs: declare arrow function parameters. This makes the context allocation less pessimistic in case of name clash. This is also required for being able to skip inner functions. BUG=v8:5501, v8:5516 Review-Url: https://codereview.chromium.org/2610823003 Cr-Commit-Position: refs/heads/master@{#42087} Committed: https://chromium.googlesource.com/v8/v8/+/8bb2501e7f8d2575d02e3a7e2fab8c431045b838

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -25 lines) Patch
M src/parsing/preparser.h View 4 chunks +31 lines, -7 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +21 lines, -18 lines 2 comments Download

Messages

Total messages: 12 (8 generated)
marja
adamk, ptal
3 years, 11 months ago (2017-01-04 14:08:02 UTC) #2
adamk
This lgtm, but I don't understand how this gets all the tests to pass. Feel ...
3 years, 11 months ago (2017-01-04 19:28:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610823003/1
3 years, 11 months ago (2017-01-05 09:36:28 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 09:38:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8bb2501e7f8d2575d02e3a7e2fab8c43104...

Powered by Google App Engine
This is Rietveld 408576698