PreParsing inner funcs: declare arrow function parameters.

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 8546 matching lines @@
       // Context allocating because we need to:
       {"function inner() { my_var; }", true},
       {"function inner() { eval(\"foo\"); }", true},
       {"function inner() { function inner2() { my_var; } }", true},
       {"function inner() { function inner2() { eval(\"foo\"); } }", true},
       {"function inner() { var {my_var : a} = {my_var}; }", true},
       {"function inner() { let {my_var : a} = {my_var}; }", true},
       {"function inner() { const {my_var : a} = {my_var}; }", true},
       {"function inner(a = my_var) { }", true},
       {"function inner() { function inner2(a = my_var) { } }", true},
+      {"function inner() { (a = my_var) => { } }", true},
       {"function inner({a} = {a: my_var}) { }", true},
       {"function inner() { function inner2({a} = {a: my_var}) { } }", true},
+      {"function inner() { ({a} = {a: my_var}) => { } }", true},
       {"function inner([a] = [my_var]) { }", true},
       {"function inner() { function inner2([a] = [my_var]) { } }", true},
+      {"function inner() { ([a] = [my_var]) => { } }", true},
       // No pessimistic context allocation:
       {"function inner() { var my_var; my_var; }", false},
       {"function inner() { var my_var; }", false},
       {"function inner() { let my_var; my_var; }", false},
       {"function inner() { let my_var; }", false},
       {"function inner() { const my_var = 0; my_var; }", false},
       {"function inner() { const my_var = 0; }", false},
       {"function inner() { var [a, my_var] = [1, 2]; my_var; }", false},
       {"function inner() { let [a, my_var] = [1, 2]; my_var; }", false},
       {"function inner() { const [a, my_var] = [1, 2]; my_var; }", false},
@@ skipping 60 matching lines @@
       {"({x: my_var}) => my_var;", false},
       {"({x: my_var}) => { }", false},
       {"({x: my_var} = {x: 0}) => my_var;", false},
       {"({x: my_var} = {x: 0}) => { }", false},
       {"({my_var}) => my_var;", false},
       {"({my_var}) => { }", false},
       {"({my_var} = {my_var: 5}) => my_var;", false},
       {"({my_var} = {my_var: 5}) => { }", false},
       {"function inner() { try { } catch (my_var) { } }", false},
       {"function inner() { class my_var {}; }", false},
+      {"function inner() { my_var => my_var; }", false},

[adamk, 2017/01/04 19:28:47]

How does this one work?

+      {"function inner() { my_var => { }}", false},
+      {"function inner() { (my_var = 5) => my_var; }", false},
+      {"function inner() { (my_var = 5) => { }}", false},
+      {"function inner() { (...my_var) => my_var;}", false},
+      {"function inner() { (...my_var) => { }}", false},
+      {"function inner() { ([a, my_var, b]) => my_var;}", false},
+      {"function inner() { ([a, my_var, b]) => { }}", false},
+      {"function inner() { ([a, my_var, b] = [1, 2, 3]) => my_var;}", false},
+      {"function inner() { ([a, my_var, b] = [1, 2, 3]) => { }}", false},
+      {"function inner() { ({x: my_var}) => my_var;}", false},
+      {"function inner() { ({x: my_var}) => { }}", false},
+      {"function inner() { ({x: my_var} = {x: 0}) => my_var;}", false},
+      {"function inner() { ({x: my_var} = {x: 0}) => { }}", false},
+      {"function inner() { ({my_var}) => my_var;}", false},

[adamk, 2017/01/04 19:28:47]

And this one?

+      {"function inner() { ({my_var}) => { }}", false},
+      {"function inner() { ({my_var} = {my_var: 5}) => my_var;}", false},
+      {"function inner() { ({my_var} = {my_var: 5}) => { }}", false},
       // In the following cases we still context allocate pessimistically:
       {"function inner() { function my_var() {} my_var; }", true},
       {"function inner() { if (true) { function my_var() {} }  my_var; }",
        true},
       {"function inner() { try { } catch (my_var) { my_var; } }", true},
       {"function inner() { for (my_var of {}) { my_var; } }", true},
       {"function inner() { for (my_var of {}) { } }", true},
       {"function inner() { for (my_var in []) { my_var; } }", true},
       {"function inner() { for (my_var in []) { } }", true},
-      {"function inner() { my_var => my_var; }", true},
-      {"function inner() { my_var => { }}", true},
-      {"function inner() { (my_var = 5) => my_var; }", true},
-      {"function inner() { (my_var = 5) => { }}", true},
-      {"function inner() { (...my_var) => my_var;}", true},
-      {"function inner() { (...my_var) => { }}", true},
-      {"function inner() { ([a, my_var, b]) => my_var;}", true},
-      {"function inner() { ([a, my_var, b]) => { }}", true},
-      {"function inner() { ([a, my_var, b] = [1, 2, 3]) => my_var;}", true},
-      {"function inner() { ([a, my_var, b] = [1, 2, 3]) => { }}", true},
-      {"function inner() { ({x: my_var}) => my_var;}", true},
-      {"function inner() { ({x: my_var}) => { }}", true},
-      {"function inner() { ({x: my_var} = {x: 0}) => my_var;}", true},
-      {"function inner() { ({x: my_var} = {x: 0}) => { }}", true},
-      {"function inner() { ({my_var}) => my_var;}", true},
-      {"function inner() { ({my_var}) => { }}", true},
-      {"function inner() { ({my_var} = {my_var: 5}) => my_var;}", true},
-      {"function inner() { ({my_var} = {my_var: 5}) => { }}", true},
       {"function inner() { class my_var {}; my_var }", true},
   };
 
   for (unsigned i = 0; i < arraysize(inners); ++i) {
     const char* inner = inners[i].source;
     int inner_len = Utf8LengthHelper(inner);
     int len = prefix_len + inner_len + suffix_len;
     i::ScopedVector<char> program(len + 1);
     i::SNPrintF(program, "%s%s%s", prefix, inner, suffix);
     i::Handle<i::String> source =
@@ skipping 13 matching lines @@
     DCHECK_NOT_NULL(scope);
     DCHECK_NULL(scope->sibling());
     DCHECK(scope->is_function_scope());
     const i::AstRawString* var_name =
         info.ast_value_factory()->GetOneByteString("my_var");
     i::Variable* var = scope->Lookup(var_name);
     CHECK_EQ(inners[i].ctxt_allocate,
              i::ScopeTestHelper::MustAllocateInContext(var));
   }
 }