[wasm] factor lower level utilties out of WasmFullDecoder

[wasm] factor lower level utilties out of WasmFullDecoder

Separated:
- decoding of locals 
- loop assignment analysis 
- determination of opcode length

as statics that work on a Decoder. Neither need the context of a 
Module, and were used in scenarios where one wasn't available either.

Changed BodyLocalDecls to match the usecases for the type. In all but 
one (a printer), we want the list (in order of declaration, with 
repetitions) of types of locals.

Removed a now-unnecessary constructor for the WasmFullDecoder.

BUG=

Review-Url: https://codereview.chromium.org/2610813009
Cr-Commit-Position: refs/heads/master@{#42115}
Committed: https://chromium.googlesource.com/v8/v8/+/ccfb815c9d234da10e9071e2349c2efab54f5006

[Mircea Trofin, 2017-01-06 19:19:49]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 19:19:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2017-01-06 19:38:33]

Description was changed from

==========
[wasm] factor lower level utilties out of WasmFullDecoder

BUG=
==========

to

==========
[wasm] factor lower level utilties out of WasmFullDecoder

Separated:
- decoding of locals 
- loop assignment analysis 
- determination of opcode length

as statics that work on a Decoder. Neither need the context of a 
Module, and were used in scenarios where one wasn't available either.

Changed BodyLocalDecls to match the usecases for the type. In all but 
one (a printer), we want the list (in order of declaration, with 
repetitions) of types of locals.

Removed a now-unnecessary constructor for the WasmFullDecoder.

BUG=
==========

[Mircea Trofin, 2017-01-06 19:38:34]

mtrofin@chromium.org changed reviewers:
+ bradnelson@chromium.org

[commit-bot: I haz the power, 2017-01-06 20:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 20:11:15]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/15119)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Mircea Trofin, 2017-01-06 21:08:37]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 21:08:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:23:55]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Mircea Trofin, 2017-01-06 21:48:15]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 21:48:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 22:14:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 22:14:59]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2017-01-06 22:23:07]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2017-01-06 22:23:07]

lgtm

[commit-bot: I haz the power, 2017-01-06 22:23:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 22:24:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483741387374840,
"parent_rev": "0d726624004489f08566f526b05deb8fe9d1efc5", "commit_rev":
"ccfb815c9d234da10e9071e2349c2efab54f5006"}

[commit-bot: I haz the power, 2017-01-06 22:25:05]

Description was changed from

==========
[wasm] factor lower level utilties out of WasmFullDecoder

Separated:
- decoding of locals 
- loop assignment analysis 
- determination of opcode length

as statics that work on a Decoder. Neither need the context of a 
Module, and were used in scenarios where one wasn't available either.

Changed BodyLocalDecls to match the usecases for the type. In all but 
one (a printer), we want the list (in order of declaration, with 
repetitions) of types of locals.

Removed a now-unnecessary constructor for the WasmFullDecoder.

BUG=
==========

to

==========
[wasm] factor lower level utilties out of WasmFullDecoder

Separated:
- decoding of locals 
- loop assignment analysis 
- determination of opcode length

as statics that work on a Decoder. Neither need the context of a 
Module, and were used in scenarios where one wasn't available either.

Changed BodyLocalDecls to match the usecases for the type. In all but 
one (a printer), we want the list (in order of declaration, with 
repetitions) of types of locals.

Removed a now-unnecessary constructor for the WasmFullDecoder.

BUG=

Review-Url: https://codereview.chromium.org/2610813009
Cr-Commit-Position: refs/heads/master@{#42115}
Committed:
https://chromium.googlesource.com/v8/v8/+/ccfb815c9d234da10e9071e2349c2efab54...
==========

[commit-bot: I haz the power, 2017-01-06 22:25:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/ccfb815c9d234da10e9071e2349c2efab54...