src/wasm/wasm-objects.cc - Issue 2610813009: [wasm] factor lower level utilties out of WasmFullDecoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-objects.cc

Issue 2610813009: [wasm] factor lower level utilties out of WasmFullDecoder (Closed)

Patch Set: harden decl decoding Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-objects.cc

diff --git a/src/wasm/wasm-objects.cc b/src/wasm/wasm-objects.cc

index 6ee5407dadbe461a318ffbcc466f1ed7a3689f23..29d08031a8f9cf790a14e90ffe456208f4cc8acf 100644

--- a/src/wasm/wasm-objects.cc

+++ b/src/wasm/wasm-objects.cc

@@ -798,7 +798,7 @@ bool WasmCompiledModule::GetPossibleBreakpoints(

BodyLocalDecls locals(&tmp);

BytecodeIterator iterator(module_start + func.code_start_offset,

module_start + func.code_end_offset, &locals);

- DCHECK_LT(0u, locals.decls_encoded_size);

+ DCHECK_LT(0u, locals.encoded_size);

for (uint32_t offset : iterator.offsets()) {

uint32_t total_offset = func.code_start_offset + offset;

if (total_offset >= end_offset) {

« no previous file with comments | « src/wasm/wasm-interpreter.cc ('k') | src/wasm/wasm-text.cc » ('j') | no next file with comments »