Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2610173005: Revert of Asserting telemetry story display name length for filename creation. (Closed)

Created:
3 years, 11 months ago by nednguyen
Modified:
3 years, 11 months ago
Reviewers:
eakuefner, eyaich1
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Asserting telemetry story display name length for filename creation. (patchset #3 id:40001 of https://codereview.chromium.org/2488743006/ ) Reason for revert: This is breaking some stories in tools/perf/ & caused catapult roll blockage (https://codereview.chromium.org/2617583004). Anyhow, those stories with long name in tools/perf should be fixed, but we should still send an announcement to telemetry-announce@ before landing this. Original issue's description: > Asserting telemetry story display name length for filename creation. > > BUG=chromium:662941 > > Review-Url: https://codereview.chromium.org/2488743006 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6342064cf8ddf225cd7f73d60eca3a7de740dcb7 TBR=eakuefner@chromium.org,eyaich@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:662941 Review-Url: https://codereview.chromium.org/2610173005 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6a6f252a320035abf4f8b7d167c21ebf29630f7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M telemetry/telemetry/page/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
M telemetry/telemetry/page/page_unittest.py View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nednguyen
Created Revert of Asserting telemetry story display name length for filename creation.
3 years, 11 months ago (2017-01-06 01:51:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610173005/1
3 years, 11 months ago (2017-01-06 01:51:06 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 02:10:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698