Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2610163006: MediaRecorder: support |timecode| and remove |m_ignoreMutedMedia|. (Closed)

Created:
3 years, 11 months ago by mcasas
Modified:
3 years, 11 months ago
Reviewers:
haraken, emircan, foolip
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Srirama, emircan+watch+mediarecorder_chromium.org, posciak+watch_chromium.org, jam, mlamouri+watch-blink_chromium.org, mcasas+watch+mediarecorder_chromium.org, feature-media-reviews_chromium.org, dglazkov+blink, darin-cc_chromium.org, eric.carlson_apple.com, mcasas+watch+vc_chromium.org, blink-reviews, xjz+watch_chromium.org, blink-reviews-api_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaRecorder: support |timecode| and remove |m_ignoreMutedMedia|. This CL - adds |timecode| [1] to the produced BlobEvents (and BlobEventInits) and wires it from the platform. - removes MediaRecorder's ignoreMutedMedia after [2] [1] https://github.com/w3c/mediacapture-record/issues/73 [2] https://github.com/w3c/mediacapture-record/issues/99 BUG=676211, 678854 Review-Url: https://codereview.chromium.org/2610163006 Cr-Commit-Position: refs/heads/master@{#442619} Committed: https://chromium.googlesource.com/chromium/src/+/ab5ae32c6233fe7938b9a0b53cf1c74918310d7a

Patch Set 1 #

Patch Set 2 : generic webexposed/global-interface-listing-expected.txt #

Patch Set 3 : Rebase video_capture_device_client.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -57 lines) Patch
M content/renderer/media/media_recorder_handler.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M content/renderer/media/media_recorder_handler_unittest.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediarecorder/BlobEvent-basic.html View 1 chunk +27 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-audio-video.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-requestData.html View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/BlobEvent.h View 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/BlobEvent.cpp View 3 chunks +13 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/BlobEvent.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/BlobEventInit.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h View 4 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp View 1 2 7 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebMediaRecorderHandlerClient.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 28 (20 generated)
mcasas
emircan@ ptal
3 years, 11 months ago (2017-01-06 02:39:08 UTC) #3
emircan
lgtm
3 years, 11 months ago (2017-01-06 19:02:55 UTC) #5
mcasas
foolip@ please RS: WebMediaRecorderHandlerClient.h and the expected.txt updates
3 years, 11 months ago (2017-01-07 00:45:09 UTC) #9
mcasas
haraken@ please RS: WebMediaRecorderHandlerClient.h and the ...expected.txt updates
3 years, 11 months ago (2017-01-09 15:35:30 UTC) #11
haraken
LGTM but this will need an approval of an API owner.
3 years, 11 months ago (2017-01-09 15:37:52 UTC) #12
foolip
https://github.com/w3c/mediacapture-record/pull/95 had LGTM by Gecko dev, so LGTM.
3 years, 11 months ago (2017-01-09 16:50:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610163006/120001
3 years, 11 months ago (2017-01-10 17:22:19 UTC) #25
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 17:27:22 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/ab5ae32c6233fe7938b9a0b53cf1...

Powered by Google App Engine
This is Rietveld 408576698