Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h

Issue 2610163006: MediaRecorder: support |timecode| and remove |m_ignoreMutedMedia|. (Closed)
Patch Set: Rebase video_capture_device_client.cc Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
diff --git a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
index 38290bc35af5550b1067d104533e27475a1b7fba..a55f2d461e9587650f33f578b8228f083b5eb531 100644
--- a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
+++ b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
@@ -47,10 +47,6 @@ class MODULES_EXPORT MediaRecorder final
MediaStream* stream() const { return m_stream.get(); }
const String& mimeType() const { return m_mimeType; }
String state() const;
- bool ignoreMutedMedia() const { return m_ignoreMutedMedia; }
- void setIgnoreMutedMedia(bool ignoreMutedMedia) {
- m_ignoreMutedMedia = ignoreMutedMedia;
- }
unsigned long videoBitsPerSecond() const { return m_videoBitsPerSecond; }
unsigned long audioBitsPerSecond() const { return m_audioBitsPerSecond; }
@@ -83,7 +79,10 @@ class MODULES_EXPORT MediaRecorder final
bool hasPendingActivity() const final { return !m_stopped; }
// WebMediaRecorderHandlerClient
- void writeData(const char* data, size_t length, bool lastInSlice) override;
+ void writeData(const char* data,
+ size_t length,
+ bool lastInSlice,
+ double timecode) override;
void onError(const WebString& message) override;
DECLARE_VIRTUAL_TRACE();
@@ -94,7 +93,7 @@ class MODULES_EXPORT MediaRecorder final
const MediaRecorderOptions&,
ExceptionState&);
- void createBlobEvent(Blob*);
+ void createBlobEvent(Blob*, double);
void stopRecording();
void scheduleDispatchEvent(Event*);
@@ -104,7 +103,6 @@ class MODULES_EXPORT MediaRecorder final
size_t m_streamAmountOfTracks;
String m_mimeType;
bool m_stopped;
- bool m_ignoreMutedMedia;
int m_audioBitsPerSecond;
int m_videoBitsPerSecond;

Powered by Google App Engine
This is Rietveld 408576698