[MD Bookmarks] Add a message to empty bookmark lists.

[MD Bookmarks] Add a message to empty bookmark lists.

This CL makes sure that empty folders will display an empty bookmarks
list with no card and a message like that in history to indicate no items
should be expected.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2610123004
Cr-Commit-Position: refs/heads/master@{#442194}
Committed: https://chromium.googlesource.com/chromium/src/+/2d7aaa5e27ab5d9d2f2ee42fc52f673ae8b2505d

[angelayang, 2017-01-05 04:08:52]

Description was changed from

==========
[MD Bookmarks] Empty folders display a message to indicate they're empty

This CL makes sure that empty folders will display an empty bookmarks
list with no card and a message like that in history to indicate no items
should be expected.

BUG=658980
==========

to

==========
[MD Bookmarks] Empty folders display a message to indicate they're empty

This CL makes sure that empty folders will display an empty bookmarks
list with no card and a message like that in history to indicate no items
should be expected.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[angelayang, 2017-01-05 04:09:09]

The CQ bit was checked by angelayang@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 04:09:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[angelayang, 2017-01-05 04:09:29]

Description was changed from

==========
[MD Bookmarks] Empty folders display a message to indicate they're empty

This CL makes sure that empty folders will display an empty bookmarks
list with no card and a message like that in history to indicate no items
should be expected.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Empty folders display a message to indicate they're empty

This CL makes sure that empty folders will display an empty bookmarks
list with no card and a message like that in history to indicate no items
should be expected.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[angelayang, 2017-01-05 04:09:29]

angelayang@google.com changed reviewers:
+ jiaxi@google.com

[commit-bot: I haz the power, 2017-01-05 05:16:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 05:16:11]

Dry run: This issue passed the CQ dry run.

[angelayang, 2017-01-05 05:38:17]

angelayang@google.com changed reviewers:
+ calamity@chromium.org, tsergeant@chromium.org

[angelayang, 2017-01-05 05:39:11]

Description was changed from

==========
[MD Bookmarks] Empty folders display a message to indicate they're empty

This CL makes sure that empty folders will display an empty bookmarks
list with no card and a message like that in history to indicate no items
should be expected.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Add a message to empty bookmark lists.

This CL makes sure that empty folders will display an empty bookmarks
list with no card and a message like that in history to indicate no items
should be expected.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[angelayang, 2017-01-05 05:41:37]

Take a look? Thanks :)

[tsergeant, 2017-01-05 06:10:33]

https://codereview.chromium.org/2610123004/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/list.html (right):

https://codereview.chromium.org/2610123004/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/list.html:26: color: #b4b4b4;
Use #6e6e6e instead (this is what History uses now, it's much easier to read).

[angelayang, 2017-01-09 00:23:17]

I changed the color :)

https://codereview.chromium.org/2610123004/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/list.html (right):

https://codereview.chromium.org/2610123004/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/list.html:26: color: #b4b4b4;
On 2017/01/05 06:10:33, tsergeant wrote:
> Use #6e6e6e instead (this is what History uses now, it's much easier to read).

Done.

[tsergeant, 2017-01-09 00:34:02]

lgtm

https://codereview.chromium.org/2610123004/diff/20001/chrome/app/bookmarks_st...
File chrome/app/bookmarks_strings.grdp (right):

https://codereview.chromium.org/2610123004/diff/20001/chrome/app/bookmarks_st...
chrome/app/bookmarks_strings.grdp:330: <message
name="IDS_MD_BOOKMARK_MANAGER_EMPTY_LIST" desc="Text on the bookmarks list that
indicates that this folder is empty.">
Nit: "indicates that a folder has no bookmarks"

(writing these descriptions is hard, but it's good to try and give more detail
than just the original string)

[angelayang, 2017-01-09 01:45:16]

Fixed the string description

https://codereview.chromium.org/2610123004/diff/20001/chrome/app/bookmarks_st...
File chrome/app/bookmarks_strings.grdp (right):

https://codereview.chromium.org/2610123004/diff/20001/chrome/app/bookmarks_st...
chrome/app/bookmarks_strings.grdp:330: <message
name="IDS_MD_BOOKMARK_MANAGER_EMPTY_LIST" desc="Text on the bookmarks list that
indicates that this folder is empty.">
On 2017/01/09 00:34:02, tsergeant wrote:
> Nit: "indicates that a folder has no bookmarks"
> 
> (writing these descriptions is hard, but it's good to try and give more detail
> than just the original string)

Yep thanks, i'll keep that in mind

[tsergeant, 2017-01-09 02:03:23]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-01-09 02:03:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2610123004/#ps40001
(title: "Improve string description.")

[commit-bot: I haz the power, 2017-01-09 02:03:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 02:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 02:17:58]

Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[tsergeant, 2017-01-09 03:55:16]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-01-09 03:55:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 04:02:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483934116878470,
"parent_rev": "f5a9a71738b5016364f138e5b729f4d87221705f", "commit_rev":
"2d7aaa5e27ab5d9d2f2ee42fc52f673ae8b2505d"}

[commit-bot: I haz the power, 2017-01-09 04:02:38]

Description was changed from

==========
[MD Bookmarks] Add a message to empty bookmark lists.

This CL makes sure that empty folders will display an empty bookmarks
list with no card and a message like that in history to indicate no items
should be expected.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Add a message to empty bookmark lists.

This CL makes sure that empty folders will display an empty bookmarks
list with no card and a message like that in history to indicate no items
should be expected.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2610123004
Cr-Commit-Position: refs/heads/master@{#442194}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d7aaa5e27ab5d9d2f2ee42fc52f...
==========

[commit-bot: I haz the power, 2017-01-09 04:02:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2d7aaa5e27ab5d9d2f2ee42fc52f...