Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 2610123004: [MD Bookmarks] Add a message to empty bookmark lists. (Closed)

Created:
3 years, 11 months ago by angelayang
Modified:
3 years, 11 months ago
Reviewers:
tsergeant, calamity, jiaxi
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Add a message to empty bookmark lists. This CL makes sure that empty folders will display an empty bookmarks list with no card and a message like that in history to indicate no items should be expected. BUG=658980 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2610123004 Cr-Commit-Position: refs/heads/master@{#442194} Committed: https://chromium.googlesource.com/chromium/src/+/2d7aaa5e27ab5d9d2f2ee42fc52f673ae8b2505d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed font color #

Total comments: 2

Patch Set 3 : Improve string description. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M chrome/app/bookmarks_strings.grdp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.html View 1 2 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
angelayang
Take a look? Thanks :)
3 years, 11 months ago (2017-01-05 05:41:37 UTC) #10
tsergeant
https://codereview.chromium.org/2610123004/diff/1/chrome/browser/resources/md_bookmarks/list.html File chrome/browser/resources/md_bookmarks/list.html (right): https://codereview.chromium.org/2610123004/diff/1/chrome/browser/resources/md_bookmarks/list.html#newcode26 chrome/browser/resources/md_bookmarks/list.html:26: color: #b4b4b4; Use #6e6e6e instead (this is what History ...
3 years, 11 months ago (2017-01-05 06:10:33 UTC) #11
angelayang
I changed the color :) https://codereview.chromium.org/2610123004/diff/1/chrome/browser/resources/md_bookmarks/list.html File chrome/browser/resources/md_bookmarks/list.html (right): https://codereview.chromium.org/2610123004/diff/1/chrome/browser/resources/md_bookmarks/list.html#newcode26 chrome/browser/resources/md_bookmarks/list.html:26: color: #b4b4b4; On 2017/01/05 ...
3 years, 11 months ago (2017-01-09 00:23:17 UTC) #12
tsergeant
lgtm https://codereview.chromium.org/2610123004/diff/20001/chrome/app/bookmarks_strings.grdp File chrome/app/bookmarks_strings.grdp (right): https://codereview.chromium.org/2610123004/diff/20001/chrome/app/bookmarks_strings.grdp#newcode330 chrome/app/bookmarks_strings.grdp:330: <message name="IDS_MD_BOOKMARK_MANAGER_EMPTY_LIST" desc="Text on the bookmarks list that ...
3 years, 11 months ago (2017-01-09 00:34:02 UTC) #13
angelayang
Fixed the string description https://codereview.chromium.org/2610123004/diff/20001/chrome/app/bookmarks_strings.grdp File chrome/app/bookmarks_strings.grdp (right): https://codereview.chromium.org/2610123004/diff/20001/chrome/app/bookmarks_strings.grdp#newcode330 chrome/app/bookmarks_strings.grdp:330: <message name="IDS_MD_BOOKMARK_MANAGER_EMPTY_LIST" desc="Text on the ...
3 years, 11 months ago (2017-01-09 01:45:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610123004/40001
3 years, 11 months ago (2017-01-09 02:03:31 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/5308)
3 years, 11 months ago (2017-01-09 02:17:58 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610123004/40001
3 years, 11 months ago (2017-01-09 03:55:28 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 04:02:39 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2d7aaa5e27ab5d9d2f2ee42fc52f...

Powered by Google App Engine
This is Rietveld 408576698