Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/resources/md_bookmarks/list.html

Issue 2610123004: [MD Bookmarks] Add a message to empty bookmark lists. (Closed)
Patch Set: Improve string description. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/bookmarks_strings.grdp ('k') | chrome/browser/resources/md_bookmarks/list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_bookmarks/list.html
diff --git a/chrome/browser/resources/md_bookmarks/list.html b/chrome/browser/resources/md_bookmarks/list.html
index 9098d7cb553719e6f22c8bcddbe3a98f8ed1fd26..2d9b163577c8d495325bd67fad2cc0f5aec5c34a 100644
--- a/chrome/browser/resources/md_bookmarks/list.html
+++ b/chrome/browser/resources/md_bookmarks/list.html
@@ -20,6 +20,16 @@
min-width: var(--card-min-width);
padding: 8px 0;
}
+
+ .centered-message {
+ align-items: center;
+ color: #6e6e6e;
+ display: flex;
+ font-size: 14px;
+ font-weight: 500;
+ height: 100%;
+ justify-content: center;
+ }
</style>
<dialog is="cr-action-menu" id="dropdown">
<button class="dropdown-item" on-tap="onEditTap_">
@@ -32,12 +42,16 @@
$i18n{menuDelete}
</button>
</dialog>
- <div id="bookmarks-card">
- <!-- TODO(angelayang): handle empty folders -->
+ <div id="bookmarks-card"
+ hidden$="[[isListEmpty_(selectedNode.children.length)]]">
<template is="dom-repeat" items="[[selectedNode.children]]" as="item">
<bookmarks-item item="[[item]]"></bookmarks-item>
</template>
</div>
+ <div class="centered-message"
+ hidden$="[[!isListEmpty_(selectedNode.children.length)]]">
+ $i18n{emptyList}
+ </div>
</template>
<script src="chrome://bookmarks/list.js"></script>
</dom-module>
« no previous file with comments | « chrome/app/bookmarks_strings.grdp ('k') | chrome/browser/resources/md_bookmarks/list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698