Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2610103003: Getting rid of SurfaceIdHandler as it is no longer needed. (Closed)

Created:
3 years, 11 months ago by mfomitchev
Modified:
3 years, 11 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Getting rid of SurfaceIdHandler as it is no longer needed. BUG=NONE Review-Url: https://codereview.chromium.org/2610103003 Cr-Commit-Position: refs/heads/master@{#441948} Committed: https://chromium.googlesource.com/chromium/src/+/67a34aac120086ec558e92fa87c2f401b14726fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -96 lines) Patch
M services/ui/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D services/ui/public/cpp/surface_id_handler.h View 1 chunk +0 lines, -32 lines 0 comments Download
M services/ui/public/cpp/window.h View 4 chunks +0 lines, -7 lines 0 comments Download
M services/ui/public/cpp/window.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M services/ui/public/cpp/window_private.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/public/cpp/window_tree_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/mus/client_surface_embedder.cc View 1 chunk +0 lines, -1 line 0 comments Download
D ui/aura/mus/surface_id_handler.h View 1 chunk +0 lines, -32 lines 0 comments Download
M ui/aura/mus/window_port_mus.h View 3 chunks +0 lines, -6 lines 0 comments Download
M ui/aura/mus/window_port_mus.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (10 generated)
mfomitchev
3 years, 11 months ago (2017-01-04 22:15:57 UTC) #3
mfomitchev
3 years, 11 months ago (2017-01-04 22:16:37 UTC) #5
sky
LGTM
3 years, 11 months ago (2017-01-04 22:21:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610103003/1
3 years, 11 months ago (2017-01-06 05:30:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/95036)
3 years, 11 months ago (2017-01-06 06:48:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610103003/1
3 years, 11 months ago (2017-01-06 15:56:08 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 16:30:13 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67a34aac120086ec558e92fa87c2...

Powered by Google App Engine
This is Rietveld 408576698