Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Side by Side Diff: ui/views/mus/pointer_watcher_event_router_unittest.cc

Issue 2610063002: Cleanup after removing views-mus code (Closed)
Patch Set: merge Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/mus/pointer_watcher_event_router2.h" 5 #include "ui/views/mus/pointer_watcher_event_router.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 #include "ui/aura/test/mus/window_tree_client_private.h" 12 #include "ui/aura/test/mus/window_tree_client_private.h"
13 #include "ui/events/event.h" 13 #include "ui/events/event.h"
14 #include "ui/views/mus/mus_client.h" 14 #include "ui/views/mus/mus_client.h"
15 #include "ui/views/pointer_watcher.h" 15 #include "ui/views/pointer_watcher.h"
(...skipping 19 matching lines...) Expand all
35 } 35 }
36 36
37 private: 37 private:
38 std::unique_ptr<ui::PointerEvent> last_event_observed_; 38 std::unique_ptr<ui::PointerEvent> last_event_observed_;
39 39
40 DISALLOW_COPY_AND_ASSIGN(TestPointerWatcher); 40 DISALLOW_COPY_AND_ASSIGN(TestPointerWatcher);
41 }; 41 };
42 42
43 } // namespace 43 } // namespace
44 44
45 class PointerWatcherEventRouter2Test : public testing::Test { 45 class PointerWatcherEventRouterTest : public testing::Test {
46 public: 46 public:
47 PointerWatcherEventRouter2Test() {} 47 PointerWatcherEventRouterTest() {}
48 ~PointerWatcherEventRouter2Test() override {} 48 ~PointerWatcherEventRouterTest() override {}
49 49
50 void OnPointerEventObserved(const ui::PointerEvent& event) { 50 void OnPointerEventObserved(const ui::PointerEvent& event) {
51 MusClient::Get()->pointer_watcher_event_router()->OnPointerEventObserved( 51 MusClient::Get()->pointer_watcher_event_router()->OnPointerEventObserved(
52 event, nullptr); 52 event, nullptr);
53 } 53 }
54 54
55 PointerWatcherEventRouter2::EventTypes event_types() const { 55 PointerWatcherEventRouter::EventTypes event_types() const {
56 return MusClient::Get()->pointer_watcher_event_router()->event_types_; 56 return MusClient::Get()->pointer_watcher_event_router()->event_types_;
57 } 57 }
58 58
59 private: 59 private:
60 DISALLOW_COPY_AND_ASSIGN(PointerWatcherEventRouter2Test); 60 DISALLOW_COPY_AND_ASSIGN(PointerWatcherEventRouterTest);
61 }; 61 };
62 62
63 TEST_F(PointerWatcherEventRouter2Test, EventTypes) { 63 TEST_F(PointerWatcherEventRouterTest, EventTypes) {
64 base::MessageLoop message_loop(base::MessageLoop::TYPE_UI); 64 base::MessageLoop message_loop(base::MessageLoop::TYPE_UI);
65 ScopedViewsTestHelper helper; 65 ScopedViewsTestHelper helper;
66 TestPointerWatcher pointer_watcher1, pointer_watcher2; 66 TestPointerWatcher pointer_watcher1, pointer_watcher2;
67 PointerWatcherEventRouter2* pointer_watcher_event_router = 67 PointerWatcherEventRouter* pointer_watcher_event_router =
68 MusClient::Get()->pointer_watcher_event_router(); 68 MusClient::Get()->pointer_watcher_event_router();
69 aura::WindowTreeClientPrivate test_api( 69 aura::WindowTreeClientPrivate test_api(
70 MusClient::Get()->window_tree_client()); 70 MusClient::Get()->window_tree_client());
71 EXPECT_FALSE(test_api.HasPointerWatcher()); 71 EXPECT_FALSE(test_api.HasPointerWatcher());
72 72
73 // Start with no moves. 73 // Start with no moves.
74 pointer_watcher_event_router->AddPointerWatcher(&pointer_watcher1, false); 74 pointer_watcher_event_router->AddPointerWatcher(&pointer_watcher1, false);
75 EXPECT_EQ(PointerWatcherEventRouter2::EventTypes::NON_MOVE_EVENTS, 75 EXPECT_EQ(PointerWatcherEventRouter::EventTypes::NON_MOVE_EVENTS,
76 event_types()); 76 event_types());
77 EXPECT_TRUE(test_api.HasPointerWatcher()); 77 EXPECT_TRUE(test_api.HasPointerWatcher());
78 78
79 // Add moves. 79 // Add moves.
80 pointer_watcher_event_router->AddPointerWatcher(&pointer_watcher2, true); 80 pointer_watcher_event_router->AddPointerWatcher(&pointer_watcher2, true);
81 EXPECT_EQ(PointerWatcherEventRouter2::EventTypes::MOVE_EVENTS, event_types()); 81 EXPECT_EQ(PointerWatcherEventRouter::EventTypes::MOVE_EVENTS, event_types());
82 EXPECT_TRUE(test_api.HasPointerWatcher()); 82 EXPECT_TRUE(test_api.HasPointerWatcher());
83 83
84 // Remove no-moves. 84 // Remove no-moves.
85 pointer_watcher_event_router->RemovePointerWatcher(&pointer_watcher1); 85 pointer_watcher_event_router->RemovePointerWatcher(&pointer_watcher1);
86 EXPECT_EQ(PointerWatcherEventRouter2::EventTypes::MOVE_EVENTS, event_types()); 86 EXPECT_EQ(PointerWatcherEventRouter::EventTypes::MOVE_EVENTS, event_types());
87 EXPECT_TRUE(test_api.HasPointerWatcher()); 87 EXPECT_TRUE(test_api.HasPointerWatcher());
88 88
89 // Remove moves. 89 // Remove moves.
90 pointer_watcher_event_router->RemovePointerWatcher(&pointer_watcher2); 90 pointer_watcher_event_router->RemovePointerWatcher(&pointer_watcher2);
91 EXPECT_EQ(PointerWatcherEventRouter2::EventTypes::NONE, event_types()); 91 EXPECT_EQ(PointerWatcherEventRouter::EventTypes::NONE, event_types());
92 EXPECT_FALSE(test_api.HasPointerWatcher()); 92 EXPECT_FALSE(test_api.HasPointerWatcher());
93 93
94 // Add moves. 94 // Add moves.
95 pointer_watcher_event_router->AddPointerWatcher(&pointer_watcher2, true); 95 pointer_watcher_event_router->AddPointerWatcher(&pointer_watcher2, true);
96 EXPECT_EQ(PointerWatcherEventRouter2::EventTypes::MOVE_EVENTS, event_types()); 96 EXPECT_EQ(PointerWatcherEventRouter::EventTypes::MOVE_EVENTS, event_types());
97 EXPECT_TRUE(test_api.HasPointerWatcher()); 97 EXPECT_TRUE(test_api.HasPointerWatcher());
98 98
99 // Add no moves. 99 // Add no moves.
100 pointer_watcher_event_router->AddPointerWatcher(&pointer_watcher1, false); 100 pointer_watcher_event_router->AddPointerWatcher(&pointer_watcher1, false);
101 EXPECT_EQ(PointerWatcherEventRouter2::EventTypes::MOVE_EVENTS, event_types()); 101 EXPECT_EQ(PointerWatcherEventRouter::EventTypes::MOVE_EVENTS, event_types());
102 EXPECT_TRUE(test_api.HasPointerWatcher()); 102 EXPECT_TRUE(test_api.HasPointerWatcher());
103 103
104 // Remove moves. 104 // Remove moves.
105 pointer_watcher_event_router->RemovePointerWatcher(&pointer_watcher2); 105 pointer_watcher_event_router->RemovePointerWatcher(&pointer_watcher2);
106 EXPECT_EQ(PointerWatcherEventRouter2::EventTypes::NON_MOVE_EVENTS, 106 EXPECT_EQ(PointerWatcherEventRouter::EventTypes::NON_MOVE_EVENTS,
107 event_types()); 107 event_types());
108 EXPECT_TRUE(test_api.HasPointerWatcher()); 108 EXPECT_TRUE(test_api.HasPointerWatcher());
109 109
110 // Remove no-moves. 110 // Remove no-moves.
111 pointer_watcher_event_router->RemovePointerWatcher(&pointer_watcher1); 111 pointer_watcher_event_router->RemovePointerWatcher(&pointer_watcher1);
112 EXPECT_EQ(PointerWatcherEventRouter2::EventTypes::NONE, event_types()); 112 EXPECT_EQ(PointerWatcherEventRouter::EventTypes::NONE, event_types());
113 EXPECT_FALSE(test_api.HasPointerWatcher()); 113 EXPECT_FALSE(test_api.HasPointerWatcher());
114 } 114 }
115 115
116 TEST_F(PointerWatcherEventRouter2Test, PointerWatcherNoMove) { 116 TEST_F(PointerWatcherEventRouterTest, PointerWatcherNoMove) {
117 base::MessageLoop message_loop(base::MessageLoop::TYPE_UI); 117 base::MessageLoop message_loop(base::MessageLoop::TYPE_UI);
118 ScopedViewsTestHelper helper; 118 ScopedViewsTestHelper helper;
119 ASSERT_TRUE(MusClient::Get()); 119 ASSERT_TRUE(MusClient::Get());
120 PointerWatcherEventRouter2* pointer_watcher_event_router = 120 PointerWatcherEventRouter* pointer_watcher_event_router =
121 MusClient::Get()->pointer_watcher_event_router(); 121 MusClient::Get()->pointer_watcher_event_router();
122 ASSERT_TRUE(pointer_watcher_event_router); 122 ASSERT_TRUE(pointer_watcher_event_router);
123 123
124 ui::PointerEvent pointer_event_down( 124 ui::PointerEvent pointer_event_down(
125 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), ui::EF_NONE, 1, 0, 125 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), ui::EF_NONE, 1, 0,
126 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_TOUCH), 126 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_TOUCH),
127 base::TimeTicks()); 127 base::TimeTicks());
128 ui::PointerEvent pointer_event_up( 128 ui::PointerEvent pointer_event_up(
129 ui::ET_POINTER_UP, gfx::Point(), gfx::Point(), ui::EF_NONE, 1, 0, 129 ui::ET_POINTER_UP, gfx::Point(), gfx::Point(), ui::EF_NONE, 1, 0,
130 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE), 130 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_MOUSE),
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 watcher1.Reset(); 179 watcher1.Reset();
180 watcher2.Reset(); 180 watcher2.Reset();
181 181
182 // Removing the last PointerWatcher stops sending events to it. 182 // Removing the last PointerWatcher stops sending events to it.
183 pointer_watcher_event_router->RemovePointerWatcher(&watcher2); 183 pointer_watcher_event_router->RemovePointerWatcher(&watcher2);
184 OnPointerEventObserved(pointer_event_down); 184 OnPointerEventObserved(pointer_event_down);
185 EXPECT_FALSE(watcher1.last_event_observed()); 185 EXPECT_FALSE(watcher1.last_event_observed());
186 EXPECT_FALSE(watcher2.last_event_observed()); 186 EXPECT_FALSE(watcher2.last_event_observed());
187 } 187 }
188 188
189 TEST_F(PointerWatcherEventRouter2Test, PointerWatcherMove) { 189 TEST_F(PointerWatcherEventRouterTest, PointerWatcherMove) {
190 base::MessageLoop message_loop(base::MessageLoop::TYPE_UI); 190 base::MessageLoop message_loop(base::MessageLoop::TYPE_UI);
191 ScopedViewsTestHelper helper; 191 ScopedViewsTestHelper helper;
192 ASSERT_TRUE(MusClient::Get()); 192 ASSERT_TRUE(MusClient::Get());
193 PointerWatcherEventRouter2* pointer_watcher_event_router = 193 PointerWatcherEventRouter* pointer_watcher_event_router =
194 MusClient::Get()->pointer_watcher_event_router(); 194 MusClient::Get()->pointer_watcher_event_router();
195 ASSERT_TRUE(pointer_watcher_event_router); 195 ASSERT_TRUE(pointer_watcher_event_router);
196 196
197 ui::PointerEvent pointer_event_down( 197 ui::PointerEvent pointer_event_down(
198 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), ui::EF_NONE, 1, 0, 198 ui::ET_POINTER_DOWN, gfx::Point(), gfx::Point(), ui::EF_NONE, 1, 0,
199 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_TOUCH), 199 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_TOUCH),
200 base::TimeTicks()); 200 base::TimeTicks());
201 ui::PointerEvent pointer_event_move( 201 ui::PointerEvent pointer_event_move(
202 ui::ET_POINTER_MOVED, gfx::Point(), gfx::Point(), ui::EF_NONE, 1, 0, 202 ui::ET_POINTER_MOVED, gfx::Point(), gfx::Point(), ui::EF_NONE, 1, 0,
203 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_TOUCH), 203 ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_TOUCH),
(...skipping 29 matching lines...) Expand all
233 watcher2.Reset(); 233 watcher2.Reset();
234 234
235 // Removing the last PointerWatcher stops sending events to it. 235 // Removing the last PointerWatcher stops sending events to it.
236 pointer_watcher_event_router->RemovePointerWatcher(&watcher2); 236 pointer_watcher_event_router->RemovePointerWatcher(&watcher2);
237 OnPointerEventObserved(pointer_event_move); 237 OnPointerEventObserved(pointer_event_move);
238 EXPECT_FALSE(watcher1.last_event_observed()); 238 EXPECT_FALSE(watcher1.last_event_observed());
239 EXPECT_FALSE(watcher2.last_event_observed()); 239 EXPECT_FALSE(watcher2.last_event_observed());
240 } 240 }
241 241
242 } // namespace views 242 } // namespace views
OLDNEW
« no previous file with comments | « ui/views/mus/pointer_watcher_event_router2_unittest.cc ('k') | ui/views/mus/run_all_unittests_aura_mus.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698