Pass camera facing to WebKit

media/capture/mojo/video_capture_types.mojom

Index: media/capture/mojo/video_capture_types.mojom
diff --git a/media/capture/mojo/video_capture_types.mojom b/media/capture/mojo/video_capture_types.mojom
index d020527b0e114c3daf5dc842852b08db4bb91c35..ce8fe83fad8b8767cd4744f0353856e48eb39247 100644
--- a/media/capture/mojo/video_capture_types.mojom
+++ b/media/capture/mojo/video_capture_types.mojom
@@ -26,6 +26,19 @@ enum VideoPixelStorage {
   GPUMEMORYBUFFER
 };
 
+// TODO(hta): crbug:680396. Consider to rename it to FacingMode.

[hta - Chromium, 2017/01/12 19:36:41]

The convention for TODO is TODO(name of person who entered the todo).

[shenghao, 2017/01/13 11:09:34]

Deleted

+enum VideoFacingMode {
+  // The source is facing toward the user (a self-view camera).
+  USER,
+  // The source is facing away from the user (viewing the environment).
+  ENVIRONMENT,
+  // The source is facing to the left of the user.
+  LEFT,
+  // The source is facing to the right of the user.
+  RIGHT,
+  NONE
+};

[hta - Chromium, 2017/01/12 19:36:41]

I don't understand what value this Mojom definition adds over the naked enum
VideoFacingMode. You seem to be using it as an enum everywhere.

[jochen (gone - plz use gerrit), 2017/01/13 08:47:09]

we should remove the other enum, and just use the mojom version everywhere (so
we don't have different enums in media and content and blink for the exact same
thing)

[shenghao, 2017/01/13 11:09:34]

After looking at hta@'s CL (https://codereview.chromium.org/2590193002/), I
don't need to modify renderer and Webkit anymore, and therefore no enum needs to
be added.

[shenghao, 2017/01/13 11:09:34]

Deleted

+
 enum VideoCaptureApi {
   LINUX_V4L2_SINGLE_PLANE,
   WIN_MEDIA_FOUNDATION,