Pass camera facing to WebKit

media/capture/mojo/video_capture_types.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module media.mojom;
 
 import "media/mojo/interfaces/media_types.mojom";
 import "mojo/common/time.mojom";
 import "mojo/common/values.mojom";
 import "ui/gfx/geometry/mojo/geometry.mojom";
 
 enum ResolutionChangePolicy {
   FIXED_RESOLUTION,
   FIXED_ASPECT_RATIO,
   ANY_WITHIN_LIMIT,
 };
 
 enum PowerLineFrequency {
   DEFAULT,
   HZ_50,
   HZ_60
 };
 
 enum VideoPixelStorage {
   CPU,
   GPUMEMORYBUFFER
 };
 
+// TODO(hta): crbug:680396. Consider to rename it to FacingMode.

[hta - Chromium, 2017/01/12 19:36:41]

The convention for TODO is TODO(name of person who entered the todo).

[shenghao, 2017/01/13 11:09:34]

Deleted

+enum VideoFacingMode {
+  // The source is facing toward the user (a self-view camera).
+  USER,
+  // The source is facing away from the user (viewing the environment).
+  ENVIRONMENT,
+  // The source is facing to the left of the user.
+  LEFT,
+  // The source is facing to the right of the user.
+  RIGHT,
+  NONE
+};

[hta - Chromium, 2017/01/12 19:36:41]

I don't understand what value this Mojom definition adds over the naked enum
VideoFacingMode. You seem to be using it as an enum everywhere.

[jochen (gone - plz use gerrit), 2017/01/13 08:47:09]

we should remove the other enum, and just use the mojom version everywhere (so
we don't have different enums in media and content and blink for the exact same
thing)

[shenghao, 2017/01/13 11:09:34]

After looking at hta@'s CL (https://codereview.chromium.org/2590193002/), I
don't need to modify renderer and Webkit anymore, and therefore no enum needs to
be added.

[shenghao, 2017/01/13 11:09:34]

Deleted

+
 enum VideoCaptureApi {
   LINUX_V4L2_SINGLE_PLANE,
   WIN_MEDIA_FOUNDATION,
   WIN_DIRECT_SHOW,
   MACOSX_AVFOUNDATION,
   MACOSX_DECKLINK,
   ANDROID_API1,
   ANDROID_API2_LEGACY,
   ANDROID_API2_FULL,
   ANDROID_API2_LIMITED,
@@ skipping 21 matching lines @@
 };
 
 struct VideoFrameInfo{
   mojo.common.mojom.TimeDelta timestamp;
   mojo.common.mojom.DictionaryValue metadata;
   VideoPixelFormat pixel_format;
   VideoPixelStorage storage_type;
   gfx.mojom.Size coded_size;
   gfx.mojom.Rect visible_rect;
 };