Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2609763002:
Don't post multiple task for executing blocked scripts. (Closed)
|
Created:
3 years, 11 months ago by rune Modified:
3 years, 11 months ago Reviewers:
Pat Meenan CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't post multiple task for executing blocked scripts.
We may post a lot of tasks for executing blocked scripts in the case
where we insert multiple shadow trees each containing a style element.
When we start parsing a style element, we mark it as blocking and
unblock script execution after finishing parsing. Check if the previous
task is active before posting.
Found while measuring performance for issue 603621.
BUG=603621
Committed: https://crrev.com/26cb3bdcd2a353402b78b716862567226317dff0
Cr-Commit-Position: refs/heads/master@{#441110}
Patch Set 1 #Patch Set 2 : Rebased #
Messages
Total messages: 19 (13 generated)
The CQ bit was checked by rune@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rune@opera.com changed reviewers: + pmeenan@chromium.org
ptal
The CQ bit was checked by rune@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483449948640780,
"parent_rev": "ed73a545ac29fa323fb70e3d84a8a23ec47c09de", "commit_rev":
"f3c05c73ba680573dca169c534b3da7137534c83"}
Message was sent while issue was closed.
Description was changed from ========== Don't post multiple task for executing blocked scripts. We may post a lot of tasks for executing blocked scripts in the case where we insert multiple shadow trees each containing a style element. When we start parsing a style element, we mark it as blocking and unblock script execution after finishing parsing. Check if the previous task is active before posting. Found while measuring performance for issue 603621. BUG=603621 ========== to ========== Don't post multiple task for executing blocked scripts. We may post a lot of tasks for executing blocked scripts in the case where we insert multiple shadow trees each containing a style element. When we start parsing a style element, we mark it as blocking and unblock script execution after finishing parsing. Check if the previous task is active before posting. Found while measuring performance for issue 603621. BUG=603621 Review-Url: https://codereview.chromium.org/2609763002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Don't post multiple task for executing blocked scripts. We may post a lot of tasks for executing blocked scripts in the case where we insert multiple shadow trees each containing a style element. When we start parsing a style element, we mark it as blocking and unblock script execution after finishing parsing. Check if the previous task is active before posting. Found while measuring performance for issue 603621. BUG=603621 Review-Url: https://codereview.chromium.org/2609763002 ========== to ========== Don't post multiple task for executing blocked scripts. We may post a lot of tasks for executing blocked scripts in the case where we insert multiple shadow trees each containing a style element. When we start parsing a style element, we mark it as blocking and unblock script execution after finishing parsing. Check if the previous task is active before posting. Found while measuring performance for issue 603621. BUG=603621 Committed: https://crrev.com/26cb3bdcd2a353402b78b716862567226317dff0 Cr-Commit-Position: refs/heads/master@{#441110} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/26cb3bdcd2a353402b78b716862567226317dff0 Cr-Commit-Position: refs/heads/master@{#441110}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2617763002/ by rune@opera.com. The reason for reverting is: Regression in test for time to first meaningful paint: https://crbug.com/678584 . |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
