xfa/fwl/cfwl_edit.cpp - Issue 2609423003: Properly ref-count CFGAS_GEFont with CFX_RetainPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/cfwl_edit.cpp

Issue 2609423003: Properly ref-count CFGAS_GEFont with CFX_RetainPtr. (Closed)

Patch Set: comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/cfwl_edit.cpp

diff --git a/xfa/fwl/cfwl_edit.cpp b/xfa/fwl/cfwl_edit.cpp

index 79b0b2d3660e6e7c9e65548225f73f958a1c3339..acd56722271504dad93cb7e20f1ec9c543760cb7 100644

--- a/xfa/fwl/cfwl_edit.cpp

+++ b/xfa/fwl/cfwl_edit.cpp

@@ -688,7 +688,7 @@ void CFWL_Edit::UpdateEditParams() {

params.dwFontColor = theme->GetTextColor(&part);

params.fLineSpace = theme->GetLineHeight(&part);

- CFGAS_GEFont* pFont = theme->GetFont(&part);

+ CFX_RetainPtr<CFGAS_GEFont> pFont = theme->GetFont(&part);

if (!pFont)

return;