xfa/fwl/cfwl_barcode.cpp - Issue 2609423003: Properly ref-count CFGAS_GEFont with CFX_RetainPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/cfwl_barcode.cpp

Issue 2609423003: Properly ref-count CFGAS_GEFont with CFX_RetainPtr. (Closed)

Patch Set: comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/cfwl_barcode.cpp

diff --git a/xfa/fwl/cfwl_barcode.cpp b/xfa/fwl/cfwl_barcode.cpp

index 8b05927223da6212e10c7c3d5b65dddb6a634ed6..0412b86958b1e24a70012f8e1f9f0fadacaf61fc 100644

--- a/xfa/fwl/cfwl_barcode.cpp

+++ b/xfa/fwl/cfwl_barcode.cpp

@@ -169,8 +169,7 @@ void CFWL_Barcode::GenerateBarcodeImageCache() {

if (pTheme) {

CFWL_ThemePart part;

part.m_pWidget = this;

- if (CFGAS_GEFont* pFont = pTheme->GetFont(&part)) {

+ if (CFX_RetainPtr<CFGAS_GEFont> pFont = pTheme->GetFont(&part)) {

if (CFX_Font* pCXFont = pFont->GetDevFont())

m_pBarcodeEngine->SetFont(pCXFont);

}