xfa/fwl/ifwl_themeprovider.h - Issue 2609423003: Properly ref-count CFGAS_GEFont with CFX_RetainPtr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/ifwl_themeprovider.h

Issue 2609423003: Properly ref-count CFGAS_GEFont with CFX_RetainPtr. (Closed)

Patch Set: comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/ifwl_themeprovider.h

diff --git a/xfa/fwl/ifwl_themeprovider.h b/xfa/fwl/ifwl_themeprovider.h

index c0460fe9011293b893bef7a9ab936e8a90e43ccf..21a12a55f2a53605afb6cee0d8c050046527efe3 100644

--- a/xfa/fwl/ifwl_themeprovider.h

+++ b/xfa/fwl/ifwl_themeprovider.h

@@ -26,7 +26,8 @@ class IFWL_ThemeProvider {

virtual float GetCYBorderSize() const = 0;

virtual CFX_RectF GetUIMargin(CFWL_ThemePart* pThemePart) const = 0;

virtual float GetFontSize(CFWL_ThemePart* pThemePart) const = 0;

- virtual CFGAS_GEFont* GetFont(CFWL_ThemePart* pThemePart) const = 0;

+ virtual CFX_RetainPtr<CFGAS_GEFont> GetFont(

+ CFWL_ThemePart* pThemePart) const = 0;

virtual float GetLineHeight(CFWL_ThemePart* pThemePart) const = 0;

virtual float GetScrollBarWidth() const = 0;

virtual FX_COLORREF GetTextColor(CFWL_ThemePart* pThemePart) const = 0;