[NTP::RecentTabs] Enable by default and depend on recent tabs flag.

[NTP::RecentTabs] Enable by default and depend on recent tabs flag.

Make Recent Tabs (aka Open Tabs) provider depend on #offlining-recent-pages.

Reason: M57 feature freeze is close and we want this provider in M57.
However, it is not clear whether recent tabs will be in M57, thus, we
enable our provider conditionally on them.

BUG=659205
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d7a20b36dbb18ae42d308a473ef868d63a87701b
Cr-Commit-Position: refs/heads/master@{#441384}

[vitaliii, 2017-01-04 13:07:23]

Description was changed from

==========
[NTP::RecentTabs] Enable by default and depend on recent tabs flag.

Make Recent Tabs (aka Open Tabs) provider depend on

Reason: M57 feature freeze is close and we want this provider in M57.
However, it is not clear whether recent tabs will be in M57, thus, we
enable our provider conditionally on them.

BUG=659205
==========

to

==========
[NTP::RecentTabs] Enable by default and depend on recent tabs flag.

Make Recent Tabs (aka Open Tabs) provider depend on

Reason: M57 feature freeze is close and we want this provider in M57.
However, it is not clear whether recent tabs will be in M57, thus, we
enable our provider conditionally on them.

BUG=659205
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[vitaliii, 2017-01-04 13:08:40]

vitaliii@chromium.org changed reviewers:
+ jkrcal@chromium.org

[vitaliii, 2017-01-04 13:08:41]

[small CL]

Hi jkrcal@,

Could you have a look?

[vitaliii, 2017-01-04 13:08:46]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 13:08:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkrcal, 2017-01-04 13:13:36]

code lgtm

just to double check: does it comply with the launching process? what happens if
we do not get launch approval? (you merge a fix to beta making it disabled by
default again?)

[vitaliii, 2017-01-04 13:18:43]

On 2017/01/04 13:13:36, jkrcal wrote:
> code lgtm
> 
> just to double check: does it comply with the launching process? 

I guess so. AFAIK it is enabled by default to have some exposure in Canary
and for launch reviewers to check during the review.

> what happens if
> we do not get launch approval? (you merge a fix to beta making it disabled by
> default again?)

My plan is to disable it by default before BP if we know for sure that we are
not launching. 
Otherwise, the merge looks ok.

[vitaliii, 2017-01-04 13:20:38]

The CQ bit was unchecked by vitaliii@chromium.org

[vitaliii, 2017-01-04 13:20:53]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 13:21:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vitaliii, 2017-01-04 13:21:33]

vitaliii@chromium.org changed reviewers:
+ bauerb@chromium.org

[vitaliii, 2017-01-04 13:21:34]

Hi bauerb@,

could you have a look at snippets_internals_.* change?

[commit-bot: I haz the power, 2017-01-04 14:32:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 14:32:26]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-01-04 16:08:39]

WebUI LGTM

[vitaliii, 2017-01-04 16:09:16]

The CQ bit was checked by vitaliii@chromium.org

[commit-bot: I haz the power, 2017-01-04 16:09:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 16:13:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483546156423570, "parent_rev":
"d06efc7e83e2de0438a49096eb2014eef0ee92f0", "commit_rev":
"d63c5689a3f6a45c50198d1c4806a5904f244f61"}

[commit-bot: I haz the power, 2017-01-04 16:13:36]

Description was changed from

==========
[NTP::RecentTabs] Enable by default and depend on recent tabs flag.

Make Recent Tabs (aka Open Tabs) provider depend on

Reason: M57 feature freeze is close and we want this provider in M57.
However, it is not clear whether recent tabs will be in M57, thus, we
enable our provider conditionally on them.

BUG=659205
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[NTP::RecentTabs] Enable by default and depend on recent tabs flag.

Make Recent Tabs (aka Open Tabs) provider depend on

Reason: M57 feature freeze is close and we want this provider in M57.
However, it is not clear whether recent tabs will be in M57, thus, we
enable our provider conditionally on them.

BUG=659205
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2609423002
==========

[commit-bot: I haz the power, 2017-01-04 16:13:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-04 16:16:46]

Description was changed from

==========
[NTP::RecentTabs] Enable by default and depend on recent tabs flag.

Make Recent Tabs (aka Open Tabs) provider depend on

Reason: M57 feature freeze is close and we want this provider in M57.
However, it is not clear whether recent tabs will be in M57, thus, we
enable our provider conditionally on them.

BUG=659205
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2609423002
==========

to

==========
[NTP::RecentTabs] Enable by default and depend on recent tabs flag.

Make Recent Tabs (aka Open Tabs) provider depend on

Reason: M57 feature freeze is close and we want this provider in M57.
However, it is not clear whether recent tabs will be in M57, thus, we
enable our provider conditionally on them.

BUG=659205
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d7a20b36dbb18ae42d308a473ef868d63a87701b
Cr-Commit-Position: refs/heads/master@{#441384}
==========

[commit-bot: I haz the power, 2017-01-04 16:16:47]

Patchset 1 (id:??) landed as
https://crrev.com/d7a20b36dbb18ae42d308a473ef868d63a87701b
Cr-Commit-Position: refs/heads/master@{#441384}

[vitaliii, 2017-01-04 16:22:40]

Description was changed from

==========
[NTP::RecentTabs] Enable by default and depend on recent tabs flag.

Make Recent Tabs (aka Open Tabs) provider depend on

Reason: M57 feature freeze is close and we want this provider in M57.
However, it is not clear whether recent tabs will be in M57, thus, we
enable our provider conditionally on them.

BUG=659205
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d7a20b36dbb18ae42d308a473ef868d63a87701b
Cr-Commit-Position: refs/heads/master@{#441384}
==========

to

==========
[NTP::RecentTabs] Enable by default and depend on recent tabs flag.

Make Recent Tabs (aka Open Tabs) provider depend on #offlining-recent-pages.

Reason: M57 feature freeze is close and we want this provider in M57.
However, it is not clear whether recent tabs will be in M57, thus, we
enable our provider conditionally on them.

BUG=659205
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d7a20b36dbb18ae42d308a473ef868d63a87701b
Cr-Commit-Position: refs/heads/master@{#441384}
==========