Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Unified Diff: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

Issue 2609423002: [NTP::RecentTabs] Enable by default and depend on recent tabs flag. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/snippets_internals.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
diff --git a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
index 24131bcd37ee0ee0bb836f453a74124dc518d5ab..7bb31372e9c68418c8eb2c17ecf99e777b59a9a4 100644
--- a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
+++ b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
@@ -61,6 +61,7 @@
#include "chrome/browser/ntp_snippets/download_suggestions_provider.h"
#include "components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h"
#include "components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h"
+#include "components/offline_pages/core/offline_page_feature.h"
#include "components/offline_pages/core/offline_page_model.h"
#include "components/physical_web/data_source/physical_web_data_source.h"
@@ -101,6 +102,14 @@ void ClearScheduledTasks() {
}
#if defined(OS_ANDROID)
+
+bool IsRecentTabProviderEnabled() {
+ return base::FeatureList::IsEnabled(
+ ntp_snippets::kRecentOfflineTabSuggestionsFeature) &&
+ base::FeatureList::IsEnabled(
+ offline_pages::kOffliningRecentPagesFeature);
+}
+
void RegisterRecentTabProvider(OfflinePageModel* offline_page_model,
ContentSuggestionsService* service,
PrefService* pref_service) {
@@ -285,8 +294,7 @@ KeyedService* ContentSuggestionsServiceFactory::BuildServiceInstanceFor(
LanguageModelFactory::GetInstance()->GetForBrowserContext(profile);
#if defined(OS_ANDROID)
- if (base::FeatureList::IsEnabled(
- ntp_snippets::kRecentOfflineTabSuggestionsFeature)) {
+ if (IsRecentTabProviderEnabled()) {
RegisterRecentTabProvider(offline_page_model, service, pref_service);
}
« no previous file with comments | « no previous file | chrome/browser/resources/snippets_internals.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698