Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 2609383002: [wrapper-tracing] Simplify tracing and reduce technical debt (Closed)

Created:
3 years, 11 months ago by Michael Lippautz
Modified:
3 years, 11 months ago
Reviewers:
haraken, Marcel Hlopko
CC:
Mads Ager (chromium), blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, kinuko+watch, kouhei+heap_chromium.org, oilpan-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Simplify tracing and reduce technical debt - Remove mixin code as we don't support those cases - Remove markAndTraceWrappers as it is not needed anymore BUG=468240 Committed: https://crrev.com/3ea9f88ef8b0dcba9d1805293cc32dbfbd678615 Cr-Commit-Position: refs/heads/master@{#441366}

Patch Set 1 #

Patch Set 2 : Proper asserts #

Patch Set 3 : Rebase on master after landing dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -59 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h View 1 7 chunks +26 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/WrapperVisitor.h View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
Michael Lippautz
Another round of removing technical debt. Eventually, the goal of all this is to move ...
3 years, 11 months ago (2017-01-04 10:19:00 UTC) #7
Michael Lippautz
On 2017/01/04 10:19:00, Michael Lippautz wrote: > Another round of removing technical debt. > > ...
3 years, 11 months ago (2017-01-04 10:20:39 UTC) #9
Marcel Hlopko
LGTM, feel free to continue on this cl if you want.
3 years, 11 months ago (2017-01-04 10:25:16 UTC) #10
haraken
LGTM
3 years, 11 months ago (2017-01-04 10:37:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609383002/40001
3 years, 11 months ago (2017-01-04 14:00:37 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2017-01-04 14:04:47 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 14:07:47 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3ea9f88ef8b0dcba9d1805293cc32dbfbd678615
Cr-Commit-Position: refs/heads/master@{#441366}

Powered by Google App Engine
This is Rietveld 408576698