third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp - Issue 2609383002: [wrapper-tracing] Simplify tracing and reduce technical debt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

Issue 2609383002: [wrapper-tracing] Simplify tracing and reduce technical debt (Closed)

Patch Set: Rebase on master after landing dep Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h ('k') | third_party/WebKit/Source/platform/heap/TraceTraits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

index a3e2680c2a80ede4f859a7c01088ae2379c99f1a..0cfb99f9a7bf48fbdcab9b2d3c77f266887ccfa7 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

@@ -189,9 +189,8 @@ TEST(ScriptWrappableVisitorTest, OilpanClearsMarkingDequeWhenObjectDied) {

ScriptWrappableVisitor* visitor =

V8PerIsolateData::from(scope.isolate())->scriptWrappableVisitor();

visitor->TracePrologue();

- visitor->pushToMarkingDeque(

- TraceTrait<DeathAwareScriptWrappable>::markAndTraceWrapper,

- TraceTrait<DeathAwareScriptWrappable>::heapObjectHeader, object);

+ visitor->markAndPushToMarkingDeque(object);

EXPECT_EQ(visitor->getMarkingDeque()->first().rawObjectPointer(), object);