Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 2609363002: [DevTools] Tweak ListControl API. (Closed)

Created:
3 years, 11 months ago by dgozman
Modified:
3 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Tweak ListControl API. BUG=none Review-Url: https://codereview.chromium.org/2609363002 Cr-Commit-Position: refs/heads/master@{#443487} Committed: https://chromium.googlesource.com/chromium/src/+/497dcf0daf5f6e6bc8b644d85a75a6816305b93a

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -1896 lines) Patch
A + third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-equal-height.js View 1 8 chunks +30 lines, -26 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-equal-height-expected.txt View 1 2 chunks +55 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-fixed-height.js View 1 chunk +0 lines, -200 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-fixed-height-expected.txt View 1 chunk +0 lines, -623 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow.js View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow-expected.txt View 1 chunk +0 lines, -280 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-non-viewport.js View 6 chunks +11 lines, -7 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-non-viewport-expected.txt View 2 chunks +26 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height.js View 1 1 chunk +0 lines, -115 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-variable-height-expected.txt View 1 1 chunk +0 lines, -325 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-various-height.js View 1 6 chunks +11 lines, -11 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-various-height-expected.txt View 1 2 chunks +17 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js View 1 7 chunks +30 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ListControl.js View 1 14 chunks +174 lines, -112 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 1 5 chunks +33 lines, -21 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
dgozman
Take a look please.
3 years, 11 months ago (2017-01-04 01:28:34 UTC) #2
pfeldman
https://codereview.chromium.org/2609363002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/ListControl.js File third_party/WebKit/Source/devtools/front_end/ui/ListControl.js (right): https://codereview.chromium.org/2609363002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/ListControl.js#newcode45 third_party/WebKit/Source/devtools/front_end/ui/ListControl.js:45: itemElementClicked(item, element, event) {}, It does not help much ...
3 years, 11 months ago (2017-01-04 02:07:50 UTC) #5
dgozman
All done, PTAL.
3 years, 11 months ago (2017-01-13 00:44:07 UTC) #8
pfeldman
lgtm
3 years, 11 months ago (2017-01-13 02:10:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609363002/20001
3 years, 11 months ago (2017-01-13 02:17:30 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 04:23:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/497dcf0daf5f6e6bc8b644d85a75...

Powered by Google App Engine
This is Rietveld 408576698