Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow.js

Issue 2609363002: [DevTools] Tweak ListControl API. (Closed)
Patch Set: fixed review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow.js b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow.js
deleted file mode 100644
index d0c19dc9692ceb4ce41166ae8a58e4a46419ce0c..0000000000000000000000000000000000000000
--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/list-control-grow.js
+++ /dev/null
@@ -1,97 +0,0 @@
-TestRunner.addResult('Test ListControl rendering and selection for grow mode.');
-
-class Delegate {
- constructor() {
- }
-
- createElementForItem(item) {
- TestRunner.addResult('Creating element for ' + item);
- var element = document.createElement('div');
- element.style.height = (10 + item % 5) + 'px';
- element.textContent = item;
- return element;
- }
-
- heightForItem(item) {
- TestRunner.addResult('heightForItem should not be called');
- return 10 + item % 5;
- }
-
- isItemSelectable(item) {
- return (item % 5 === 0) || (item % 5 === 2);
- }
-
- selectedItemChanged(from, to, fromElement, toElement) {
- TestRunner.addResult('Selection changed from ' + from + ' to ' + to);
- if (fromElement)
- fromElement.classList.remove('selected');
- if (toElement)
- toElement.classList.add('selected');
- }
-}
-
-var delegate = new Delegate();
-var list = new UI.ListControl(delegate, UI.ListMode.Grow);
-UI.inspectorView.element.appendChild(list.element);
-
-function dumpList()
-{
- var height = list.element.offsetHeight;
- TestRunner.addResult(`----list[length=${list.length()}][height=${height}]----`);
- for (var child of list.element.children) {
- var offsetTop = child.getBoundingClientRect().top - list.element.getBoundingClientRect().top;
- var offsetBottom = child.getBoundingClientRect().bottom - list.element.getBoundingClientRect().top;
- var visible = (offsetBottom <= 0 || offsetTop >= height) ? ' ' :
- (offsetTop >= 0 && offsetBottom <= height ? '*' : '+');
- var selected = child.classList.contains('selected') ? ' (selected)' : '';
- var text = child === list._topElement ? 'top' : (child === list._bottomElement ? 'bottom' : child.textContent);
- TestRunner.addResult(`${visible}[${offsetTop}] ${text}${selected}`);
- }
- TestRunner.addResult('');
-}
-
-TestRunner.addResult('Adding 0, 1, 2');
-list.replaceAllItems([0, 1, 2]);
-dumpList();
-
-TestRunner.addResult('Scrolling to 0');
-list.scrollItemAtIndexIntoView(0);
-dumpList();
-
-TestRunner.addResult('Scrolling to 2');
-list.scrollItemAtIndexIntoView(2);
-dumpList();
-
-TestRunner.addResult('Adding 3-20');
-list.replaceItemsInRange(3, 3, [3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19]);
-dumpList();
-
-TestRunner.addResult('Scrolling to 19');
-list.scrollItemAtIndexIntoView(19);
-dumpList();
-
-TestRunner.addResult('Replacing 0, 1 with 25-36');
-list.replaceItemsInRange(0, 2, [25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36]);
-dumpList();
-
-TestRunner.addResult('Scrolling to 18');
-list.scrollItemAtIndexIntoView(28);
-dumpList();
-
-TestRunner.addResult('Replacing 25-36 with 0-1');
-list.replaceItemsInRange(0, 12, [0, 1]);
-dumpList();
-
-TestRunner.addResult('Replacing 16-18 with 45');
-list.replaceItemsInRange(16, 19, [45]);
-dumpList();
-
-TestRunner.addResult('Scrolling to 4');
-list.scrollItemAtIndexIntoView(4);
-dumpList();
-
-TestRunner.addResult('Replacing 45 with 16-18');
-list.replaceItemsInRange(16, 17, [16, 17, 18]);
-dumpList();
-
-TestRunner.completeTest();

Powered by Google App Engine
This is Rietveld 408576698