Added isolate + thread high watermark tracking to Observatory

runtime/vm/isolate.h

Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index 88df144a37db1f63bf92d2df1e90c4a8e926525a..0f164ec9d95805b55ce151af4780f2216e74fa63 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -178,7 +178,9 @@ class Isolate : public BaseIsolate {
 
   ThreadRegistry* thread_registry() const { return thread_registry_; }
   SafepointHandler* safepoint_handler() const { return safepoint_handler_; }
-
+  intptr_t GetIsolateHighWatermark() const {

[Cutch, 2017/01/03 20:58:54]

style guide for simple getters says this should be:

intptr_t isolate_memory_high_watermark() const {
  return isolate_memory_high_watermark_;
}

[bkonyi, 2017/01/03 22:00:38]

Done. Would you mind telling me which design doc this is in? I have a feeling I
don't have the correct one.

+    return isolate_memory_high_watermark_;
+  }
   ClassTable* class_table() { return &class_table_; }
   static intptr_t class_table_offset() {
     return OFFSET_OF(Isolate, class_table_);
@@ -694,6 +696,10 @@ class Isolate : public BaseIsolate {
                         bool is_mutator,
                         bool bypass_safepoint = false);
 
+  // Updates the maximum memory usage in bytes of all zones in all threads of
+  // the current isolate.
+  void UpdateIsolateHighWatermark();
+
   // DEPRECATED: Use Thread's methods instead. During migration, these default
   // to using the mutator thread (which must also be the current thread).
   Zone* current_zone() const {
@@ -714,6 +720,7 @@ class Isolate : public BaseIsolate {
 
   ThreadRegistry* thread_registry_;
   SafepointHandler* safepoint_handler_;
+  intptr_t isolate_memory_high_watermark_;

[Cutch, 2017/01/03 20:58:54]

uint?

[bkonyi, 2017/01/03 22:00:38]

Since this is an amount of memory used, should it not be intptr_t?

[Cutch, 2017/01/03 22:28:00]

1) Memory usage can never be negative.

2) Memory usage can exceed the positive range of an intptr_t. Think of a 32-bit
machine with 3GB of memory allocated. A 32-bit intptr_t can only represent up to
positive ~2 billion.

[bkonyi, 2017/01/04 00:31:54]

Done.

   Dart_MessageNotifyCallback message_notify_callback_;
   char* name_;
   char* debugger_name_;