Added isolate + thread high watermark tracking to Observatory

runtime/vm/isolate.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_ISOLATE_H_
 #define RUNTIME_VM_ISOLATE_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/atomic.h"
@@ skipping 160 matching lines @@
   // Visits weak object pointers.
   void VisitWeakPersistentHandles(HandleVisitor* visitor);
 
   // Prepares all threads in an isolate for Garbage Collection.
   void PrepareForGC();
 
   StoreBuffer* store_buffer() { return store_buffer_; }
 
   ThreadRegistry* thread_registry() const { return thread_registry_; }
   SafepointHandler* safepoint_handler() const { return safepoint_handler_; }
-
+  intptr_t GetIsolateHighWatermark() const {

[Cutch, 2017/01/03 20:58:54]

style guide for simple getters says this should be:

intptr_t isolate_memory_high_watermark() const {
  return isolate_memory_high_watermark_;
}

[bkonyi, 2017/01/03 22:00:38]

Done. Would you mind telling me which design doc this is in? I have a feeling I
don't have the correct one.

+    return isolate_memory_high_watermark_;
+  }
   ClassTable* class_table() { return &class_table_; }
   static intptr_t class_table_offset() {
     return OFFSET_OF(Isolate, class_table_);
   }
 
   // Prefers old classes when we are in the middle of a reload.
   RawClass* GetClassForHeapWalkAt(intptr_t cid);
 
   static intptr_t ic_miss_code_offset() {
     return OFFSET_OF(Isolate, ic_miss_code_);
@@ skipping 495 matching lines @@
   }
   void set_registered_service_extension_handlers(
       const GrowableObjectArray& value);
 
   Monitor* threads_lock() const;
   Thread* ScheduleThread(bool is_mutator, bool bypass_safepoint = false);
   void UnscheduleThread(Thread* thread,
                         bool is_mutator,
                         bool bypass_safepoint = false);
 
+  // Updates the maximum memory usage in bytes of all zones in all threads of
+  // the current isolate.
+  void UpdateIsolateHighWatermark();
+
   // DEPRECATED: Use Thread's methods instead. During migration, these default
   // to using the mutator thread (which must also be the current thread).
   Zone* current_zone() const {
     ASSERT(Thread::Current() == mutator_thread());
     return mutator_thread()->zone();
   }
 
   // Accessed from generated code:
   StoreBuffer* store_buffer_;
   Heap* heap_;
   uword user_tag_;
   RawUserTag* current_tag_;
   RawUserTag* default_tag_;
   RawCode* ic_miss_code_;
   ObjectStore* object_store_;
   ClassTable class_table_;
   bool single_step_;
 
   ThreadRegistry* thread_registry_;
   SafepointHandler* safepoint_handler_;
+  intptr_t isolate_memory_high_watermark_;

[Cutch, 2017/01/03 20:58:54]

uint?

[bkonyi, 2017/01/03 22:00:38]

Since this is an amount of memory used, should it not be intptr_t?

[Cutch, 2017/01/03 22:28:00]

1) Memory usage can never be negative.

2) Memory usage can exceed the positive range of an intptr_t. Think of a 32-bit
machine with 3GB of memory allocated. A 32-bit intptr_t can only represent up to
positive ~2 billion.

[bkonyi, 2017/01/04 00:31:54]

Done.

   Dart_MessageNotifyCallback message_notify_callback_;
   char* name_;
   char* debugger_name_;
   int64_t start_time_micros_;
   Dart_Port main_port_;
   Dart_Port origin_id_;  // Isolates created by spawnFunc have some origin id.
   uint64_t pause_capability_;
   uint64_t terminate_capability_;
   bool errors_fatal_;
   void* init_callback_data_;
@@ skipping 266 matching lines @@
   intptr_t* spawn_count_;
 
   Dart_IsolateFlags isolate_flags_;
   bool paused_;
   bool errors_are_fatal_;
 };
 
 }  // namespace dart
 
 #endif  // RUNTIME_VM_ISOLATE_H_