Chromium Code Reviews| Index: runtime/observatory/lib/src/elements/isolate_view.dart |
| diff --git a/runtime/observatory/lib/src/elements/isolate_view.dart b/runtime/observatory/lib/src/elements/isolate_view.dart |
| index ef157c09efa87c68edca2330885f7d294d5006ef..3d088d69bdfc58025437c644366e7db6224e1f8f 100644 |
| --- a/runtime/observatory/lib/src/elements/isolate_view.dart |
| +++ b/runtime/observatory/lib/src/elements/isolate_view.dart |
| @@ -277,6 +277,17 @@ class IsolateViewElement extends HtmlElement implements Renderable { |
| ..text = 'object store' |
| ] |
| ], |
| + new DivElement() |
| + ..classes = ['memberItem'] |
| + ..children = [ |
| + new DivElement() |
| + ..classes = ['memberName'] |
| + ..text = 'high watermark', |
|
Cutch
2017/01/03 20:58:54
This needs more context and probably a title attri
bkonyi
2017/01/03 22:00:37
I'll go ahead and change this to "memory high wate
Cutch
2017/01/03 22:28:00
"memory high watermark" also isn't precise enough.
bkonyi
2017/01/04 00:31:54
Done.
|
| + new DivElement() |
| + ..classes = ['memberValue'] |
| + ..text = Utils.formatSize(_isolate.memoryHighWatermark) |
| + ..title = '${_isolate.memoryHighWatermark}B' |
| + ], |
| new BRElement(), |
| new DivElement() |
| ..classes = ['memberItem'] |
| @@ -343,6 +354,11 @@ class IsolateViewElement extends HtmlElement implements Renderable { |
| ..classes = ['indent'] |
| ..text = 'kind ${t.kindString}', |
| new DivElement() |
| + ..classes = ['indent'] |
| + ..title = '${t.memoryHighWatermark}B' |
| + ..text = |
| + 'high watermark ${Utils.formatSize(t.memoryHighWatermark)}', |
| + new DivElement() |
| ..children = t.zones |
| .map((z) => new DivElement() |
| ..classes = ['indent'] |