Added isolate + thread high watermark tracking to Observatory

runtime/observatory/lib/src/elements/isolate_view.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library isolate_view_element;
 
 import 'dart:async';
 import 'dart:html';
 import 'package:observatory/models.dart' as M;
 import 'package:observatory/src/elements/curly_block.dart';
@@ skipping 259 matching lines @@
                   new DivElement()
                     ..classes = ['memberName']
                     ..text = 'object store',
                   new DivElement()
                     ..classes = ['memberValue']
                     ..children = [
                       new AnchorElement(href: Uris.objectStore(_isolate))
                         ..text = 'object store'
                     ]
                 ],
+              new DivElement()
+                ..classes = ['memberItem']
+                ..children = [
+                  new DivElement()
+                    ..classes = ['memberName']
+                    ..text = 'high watermark',

[Cutch, 2017/01/03 20:58:54]

This needs more context and probably a title attribute.

What precisely is this a high watermark of?

[bkonyi, 2017/01/03 22:00:37]

I'll go ahead and change this to "memory high watermark".

[Cutch, 2017/01/03 22:28:00]

"memory high watermark" also isn't precise enough. "high watermark of native
memory usage" (or something like that) will help people understand that it isn't
a high watermark of the Dart program's memory usage.

[bkonyi, 2017/01/04 00:31:54]

Done.

+                  new DivElement()
+                    ..classes = ['memberValue']
+                    ..text = Utils.formatSize(_isolate.memoryHighWatermark)
+                    ..title = '${_isolate.memoryHighWatermark}B'
+                ],
               new BRElement(),
               new DivElement()
                 ..classes = ['memberItem']
                 ..children = [
                   new DivElement()
                     ..classes = ['memberName']
                     ..text = 'libraries (${libraries.length})',
                   new DivElement()
                     ..classes = ['memberValue']
                     ..children = [
@@ skipping 46 matching lines @@
       ..classes = ['indent']
       ..children = [
         new SpanElement()
           ..text = '${t.id} ',
         new CurlyBlockElement(queue: _r.queue)
           ..content = [
             new DivElement()
               ..classes = ['indent']
               ..text = 'kind ${t.kindString}',
             new DivElement()
+              ..classes = ['indent']
+              ..title = '${t.memoryHighWatermark}B'
+              ..text =
+              'high watermark ${Utils.formatSize(t.memoryHighWatermark)}',
+            new DivElement()
               ..children = t.zones
                 .map((z) => new DivElement()
                 ..classes = ['indent']
                 ..children = [
                   new DivElement()
                     ..children = [
                       new SpanElement()
                         ..children = [
                           new SpanElement()
                             ..text = 'zone ${index++} ',
@@ skipping 43 matching lines @@
       _function = await _functions.get(_isolate, frame.function.id);
     }
     if (_isolate.rootLibrary != null) {
       final rootLibrary =
           await _libraries.get(_isolate, _isolate.rootLibrary.id);
       _rootScript = rootLibrary.rootScript;
     }
     _r.dirty();
   }
 }