Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 2609163003: Fix race in SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe. (Closed)

Created:
3 years, 11 months ago by engedy
Modified:
3 years, 11 months ago
Reviewers:
melandory
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix race in SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe. Ensure server-supplied content for the 404 error page. This prevents showing Chrome's built in error page, which would trigger a background request to load navigation corrections (aka. Link Doctor), and once the results are back, would make a navigation to a second error page containing the suggestions, which, unfortunately, makes WaitForLoadStop() in NavigateToURL() racey. BUG=677819 Committed: https://crrev.com/5fb9af565efc05fe461fb27117a5419a6f04de69 Cr-Commit-Position: refs/heads/master@{#441116}

Patch Set 1 : Remove LOG statements. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/subresource_filter/subresource_filter_browsertest.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
engedy
Tanja, PTAL.
3 years, 11 months ago (2017-01-03 13:36:28 UTC) #5
melandory
On 2017/01/03 13:36:28, engedy wrote: > Tanja, PTAL. LGTM
3 years, 11 months ago (2017-01-03 13:38:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609163003/20001
3 years, 11 months ago (2017-01-03 13:38:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
3 years, 11 months ago (2017-01-03 14:15:18 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 14:18:29 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fb9af565efc05fe461fb27117a5419a6f04de69
Cr-Commit-Position: refs/heads/master@{#441116}

Powered by Google App Engine
This is Rietveld 408576698