Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2660)

Unified Diff: chrome/browser/subresource_filter/subresource_filter_browsertest.cc

Issue 2609163003: Fix race in SubresourceFilterBrowserTest.FailedProvisionalLoadInMainframe. (Closed)
Patch Set: Remove LOG statements. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/subresource_filter/subresource_filter_browsertest.cc
diff --git a/chrome/browser/subresource_filter/subresource_filter_browsertest.cc b/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
index 20a9214eeb9a644d92a6bba2dc2f75b1d812b459..917edd83c5fc670759a89e6e9fdd6ed5bd3a1668 100644
--- a/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
+++ b/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
@@ -427,12 +427,17 @@ IN_PROC_BROWSER_TEST_F(SubresourceFilterBrowserTest,
kSubframeNames, kExpectScriptInFrameToLoadWithActivation));
}
-// Flaky on all platforms. See: https://crbug.com/677819.
IN_PROC_BROWSER_TEST_F(SubresourceFilterBrowserTest,
- DISABLED_FailedProvisionalLoadInMainframe) {
+ FailedProvisionalLoadInMainframe) {
GURL url_with_activation_but_dns_error(
"http://host-with-dns-lookup-failure/");
- GURL url_with_activation_but_not_existent(GetTestUrl("non-existent.html"));
+ // The /echo handler returns a 404 with a non-empty response body (containing
+ // the text 'Echo`). The latter is important to suppress showing Chrome's own
+ // navigation error page, in which case a background request is started to
+ // load navigation corrections (aka. Link Doctor), and once the results are
+ // back, there is a navigation to a second error page with the suggestions,
+ // which makes WaitForLoadStop() in the second NavigateToURL() below racey.
+ GURL url_with_activation_but_not_existent(GetTestUrl("/echo?status=404"));
GURL url_without_activation(GetTestUrl(kTestFrameSetPath));
ConfigureAsPhishingURL(url_with_activation_but_dns_error);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698