Generated writing-mode in ComputedStyleBase

Generated writing-mode in ComputedStyleBase

Moved writing-mode to be generated in ComputedStyleBase, which uses the
external type platform/text/WritingMode. Also added functionality to
add 'get' to the front of getters that have names that will conflict
with type names once the Blink rename has happened (and all methods
start with a capital letter).

BUG=628043
Committed: https://crrev.com/45275e78b2a5100be570bb8ca1e79989b9db00ff
Cr-Commit-Position: refs/heads/master@{#441271}

[sashab, 2017-01-03 04:55:14]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 04:55:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-01-03 04:55:49]

sashab@chromium.org changed reviewers:
+ alancutter@chromium.org, dcheng@chromium.org

[sashab, 2017-01-03 04:55:49]

dcheng fyi - see comment in build/scripts/make_computed_style_base.py

you might have to change this to 'Get' as part of your rename :)

[alancutter (OOO until 2018), 2017-01-03 05:05:15]

lgtm

[commit-bot: I haz the power, 2017-01-03 07:00:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 07:00:59]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-01-04 00:44:55]

lgtm

CC other rewrite people as fyi

[sashab, 2017-01-04 00:45:58]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-01-04 00:46:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 00:52:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483490758662010, "parent_rev":
"8130191b73f8e7a207840d3d7bbec9243b9d4825", "commit_rev":
"d4d9d8921d065b9b480bd8e390ee9def55b372e3"}

[commit-bot: I haz the power, 2017-01-04 00:53:20]

Description was changed from

==========
Generated writing-mode in ComputedStyleBase

Moved writing-mode to be generated in ComputedStyleBase, which uses the
external type platform/text/WritingMode. Also added functionality to
add 'get' to the front of getters that have names that will conflict
with type names once the Blink rename has happened (and all methods
start with a capital letter).

BUG=628043
==========

to

==========
Generated writing-mode in ComputedStyleBase

Moved writing-mode to be generated in ComputedStyleBase, which uses the
external type platform/text/WritingMode. Also added functionality to
add 'get' to the front of getters that have names that will conflict
with type names once the Blink rename has happened (and all methods
start with a capital letter).

BUG=628043

Review-Url: https://codereview.chromium.org/2609133002
==========

[commit-bot: I haz the power, 2017-01-04 00:53:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-04 00:56:29]

Description was changed from

==========
Generated writing-mode in ComputedStyleBase

Moved writing-mode to be generated in ComputedStyleBase, which uses the
external type platform/text/WritingMode. Also added functionality to
add 'get' to the front of getters that have names that will conflict
with type names once the Blink rename has happened (and all methods
start with a capital letter).

BUG=628043

Review-Url: https://codereview.chromium.org/2609133002
==========

to

==========
Generated writing-mode in ComputedStyleBase

Moved writing-mode to be generated in ComputedStyleBase, which uses the
external type platform/text/WritingMode. Also added functionality to
add 'get' to the front of getters that have names that will conflict
with type names once the Blink rename has happened (and all methods
start with a capital letter).

BUG=628043

Committed: https://crrev.com/45275e78b2a5100be570bb8ca1e79989b9db00ff
Cr-Commit-Position: refs/heads/master@{#441271}
==========

[commit-bot: I haz the power, 2017-01-04 00:56:30]

Patchset 1 (id:??) landed as
https://crrev.com/45275e78b2a5100be570bb8ca1e79989b9db00ff
Cr-Commit-Position: refs/heads/master@{#441271}

[sashab, 2017-01-10 01:54:53]

sashab@chromium.org changed reviewers:
+ napper@chromium.org

[sashab, 2017-01-10 01:54:53]

+napper FYI... Ignoring the changes in make_computed_style_base.py, this is what
generating platform/ value fields now look like -- adding
field_storage_type=platform/text/WritingMode to CSSProperties.in.

The generated code comes out the same as the other fields, except the header
file is included rather than the enum being generated :)