Generated writing-mode in ComputedStyleBase

third_party/WebKit/Source/build/scripts/make_computed_style_base.py

 #!/usr/bin/env python
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import math
 import sys
 
 import in_generator
 import template_expander
@@ skipping 86 matching lines @@
                 field_name = 'm_' + property_name_lower
                 bits_needed = math.log(len(property['keywords']), 2)
 
                 # Separate the type path from the type name, if specified.
                 type_name = property['type_name']
                 type_path = None
                 if property['field_storage_type']:
                     type_path = property['field_storage_type']
                     type_name = type_path.split('/')[-1]
 
+                # For now, the getter name should match the field name. Later, getter names
+                # will start with an uppercase letter, so if they conflict with the type name,
+                # add 'get' to the front.
+                getter_method_name = property_name_lower
+                if type_name == property_name:
+                    getter_method_name = 'get' + property_name
+
                 assert property['initial_keyword'] is not None, \
                     ('MakeComputedStyleBase requires an initial keyword for keyword_only values, none specified '
                      'for property ' + property['name'])
                 default_value = type_name + '::' + camel_case(property['initial_keyword'])
 
                 # If the property is independent, add the single-bit sized isInherited flag
                 # to the list of Fields as well.
                 if property['independent']:
                     field_name_suffix_upper = property_name + 'IsInherited'
                     field_name_suffix_lower = property_name_lower + 'IsInherited'
@@ skipping 15 matching lines @@
                 self._fields.append(Field(
                     'enum',
                     name=field_name,
                     property_name=property['name'],
                     inherited=property['inherited'],
                     independent=property['independent'],
                     storage_type=type_name,
                     storage_type_path=type_path,
                     size=int(math.ceil(bits_needed)),
                     default_value=default_value,
-                    getter_method_name=property_name_lower,
+                    getter_method_name=getter_method_name,
                     setter_method_name='set' + property_name,
                     initial_method_name='initial' + property_name,
                     resetter_method_name='reset' + property_name,
                     is_inherited_method_name=property_name_lower + 'IsInherited',
                 ))
 
         # Small optimization: order fields by size, from largest to smallest,
         # to reduce wasted space from alignment.
         self._fields.sort(key=lambda f: f.size, reverse=True)
 
@@ skipping 16 matching lines @@
     @template_expander.use_jinja('ComputedStyleBaseConstants.h.tmpl')
     def generate_base_computed_style_constants(self):
         return {
             'properties': self._properties,
             'enums': self._computed_enums,
             'fields': self._fields,
         }
 
 if __name__ == '__main__':
     in_generator.Maker(ComputedStyleBaseWriter).main(sys.argv)