Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2609013002: [turbofan] Use InternalizedString feedback abstract/strict equality comparisons. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use InternalizedString feedback abstract/strict equality comparisons. Add machinery to Ignition and TurboFan to collect and consume InternalizedString feedback for abstract and strict equality comparisons. Here we can turn the comparison into a simple pointer equality check. R=jarin@chromium.org BUG=v8:5786 Review-Url: https://codereview.chromium.org/2609013002 Cr-Commit-Position: refs/heads/master@{#42008} Committed: https://chromium.googlesource.com/v8/v8/+/b617335623909fd9179449443ee514c5b2be3c15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -17 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +35 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 5 chunks +45 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/redundancy-elimination.cc View 2 chunks +9 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/globals.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +45 lines, -8 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/type-hints.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/type-hints.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/type-info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-02 09:20:42 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-02 10:30:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609013002/1
3 years, 11 months ago (2017-01-02 11:55:13 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 11:58:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b617335623909fd9179449443ee514c5b2b...

Powered by Google App Engine
This is Rietveld 408576698