Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2608903002: VM: x64: Use correct register in write barrier to avoid an extra loop iteration (Closed)

Created:
3 years, 11 months ago by erikcorry
Modified:
3 years, 11 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: x64: Use correct register in write barrier to avoid an extra loop iteration R=regis@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e0536c1f2661fb54745d2361b1bb056e51680b8b

Patch Set 1 #

Patch Set 2 : VM: x64: Use correct register in write barrier to avoid an extra loop iteration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/stub_code_x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
regis
Good catch! lgtm
3 years, 11 months ago (2016-12-30 20:09:47 UTC) #1
erikcorry
3 years, 11 months ago (2017-01-02 08:28:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e0536c1f2661fb54745d2361b1bb056e51680b8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698