Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 2608903002: VM: x64: Use correct register in write barrier to avoid an extra loop iteration (Closed)
Patch Set: VM: x64: Use correct register in write barrier to avoid an extra loop iteration Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_x64.cc
diff --git a/runtime/vm/stub_code_x64.cc b/runtime/vm/stub_code_x64.cc
index 0341f268f80c2de6cae68d9a28c65721deed2864..b3b18da03bced6a40ab816a2f32e0ad70fb3dc79 100644
--- a/runtime/vm/stub_code_x64.cc
+++ b/runtime/vm/stub_code_x64.cc
@@ -1006,8 +1006,8 @@ void StubCode::GenerateUpdateStoreBufferStub(Assembler* assembler) {
// RDX: Address being stored
Label reload;
__ Bind(&reload);
- __ movq(RCX, FieldAddress(RDX, Object::tags_offset()));
- __ testq(RCX, Immediate(1 << RawObject::kRememberedBit));
+ __ movq(RAX, FieldAddress(RDX, Object::tags_offset()));
+ __ testq(RAX, Immediate(1 << RawObject::kRememberedBit));
__ j(EQUAL, &add_to_buffer, Assembler::kNearJump);
__ popq(RCX);
__ popq(RAX);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698