Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: runtime/vm/stub_code_x64.cc

Issue 2608903002: VM: x64: Use correct register in write barrier to avoid an extra loop iteration (Closed)
Patch Set: VM: x64: Use correct register in write barrier to avoid an extra loop iteration Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 988 matching lines...) Expand 10 before | Expand all | Expand 10 after
999 __ pushq(RAX); 999 __ pushq(RAX);
1000 __ pushq(RCX); 1000 __ pushq(RCX);
1001 1001
1002 Label add_to_buffer; 1002 Label add_to_buffer;
1003 // Check whether this object has already been remembered. Skip adding to the 1003 // Check whether this object has already been remembered. Skip adding to the
1004 // store buffer if the object is in the store buffer already. 1004 // store buffer if the object is in the store buffer already.
1005 // Spilled: RAX, RCX 1005 // Spilled: RAX, RCX
1006 // RDX: Address being stored 1006 // RDX: Address being stored
1007 Label reload; 1007 Label reload;
1008 __ Bind(&reload); 1008 __ Bind(&reload);
1009 __ movq(RCX, FieldAddress(RDX, Object::tags_offset())); 1009 __ movq(RAX, FieldAddress(RDX, Object::tags_offset()));
1010 __ testq(RCX, Immediate(1 << RawObject::kRememberedBit)); 1010 __ testq(RAX, Immediate(1 << RawObject::kRememberedBit));
1011 __ j(EQUAL, &add_to_buffer, Assembler::kNearJump); 1011 __ j(EQUAL, &add_to_buffer, Assembler::kNearJump);
1012 __ popq(RCX); 1012 __ popq(RCX);
1013 __ popq(RAX); 1013 __ popq(RAX);
1014 __ ret(); 1014 __ ret();
1015 1015
1016 // Update the tags that this object has been remembered. 1016 // Update the tags that this object has been remembered.
1017 // RDX: Address being stored 1017 // RDX: Address being stored
1018 // RAX: Current tag value 1018 // RAX: Current tag value
1019 __ Bind(&add_to_buffer); 1019 __ Bind(&add_to_buffer);
1020 __ movq(RCX, RAX); 1020 __ movq(RCX, RAX);
(...skipping 1255 matching lines...) Expand 10 before | Expand all | Expand 10 after
2276 } 2276 }
2277 2277
2278 2278
2279 void StubCode::GenerateFrameAwaitingMaterializationStub(Assembler* assembler) { 2279 void StubCode::GenerateFrameAwaitingMaterializationStub(Assembler* assembler) {
2280 __ int3(); 2280 __ int3();
2281 } 2281 }
2282 2282
2283 } // namespace dart 2283 } // namespace dart
2284 2284
2285 #endif // defined TARGET_ARCH_X64 2285 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698