Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2608893002: [builtins] Move LoadGlobalICStub to builtins (Closed)

Created:
3 years, 11 months ago by mvstanton
Modified:
3 years, 11 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Move LoadGlobalICStub to builtins Following in the footsteps of the other load/store ICs. R=epertoso@chromium.org BUG= Review-Url: https://codereview.chromium.org/2608893002 Cr-Commit-Position: refs/heads/master@{#42002} Committed: https://chromium.googlesource.com/v8/v8/+/b2119937404ef2526222b042104a4b1d53b81c0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -99 lines) Patch
M src/builtins/builtins.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/builtins/builtins-ic.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M src/code-stubs.h View 4 chunks +1 line, -51 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ic/accessor-assembler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/ic-state.h View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
mvstanton
Hi Enrico, Here is the "last" of the stubs that needs to become builtins for ...
3 years, 11 months ago (2016-12-30 12:57:05 UTC) #3
epertoso
lgtm
3 years, 11 months ago (2016-12-30 13:24:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608893002/1
3 years, 11 months ago (2016-12-30 13:35:12 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2016-12-30 13:37:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b2119937404ef2526222b042104a4b1d53b...

Powered by Google App Engine
This is Rietveld 408576698