Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: src/code-stubs.h

Issue 2608893002: [builtins] Move LoadGlobalICStub to builtins (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index a717f4c749a5cd1284aac93c3c75b4e68348a629..62203c37a7543db7c12cb78e02baf4858da69939 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -49,7 +49,6 @@ class Node;
V(StoreBufferOverflow) \
V(StoreElement) \
V(SubString) \
- V(LoadGlobalIC) \
V(FastNewRestParameter) \
V(FastNewSloppyArguments) \
V(FastNewStrictArguments) \
@@ -110,11 +109,7 @@ class Node;
V(LoadApiGetter) \
V(LoadIndexedInterceptor) \
V(LoadField) \
- V(GrowArrayElements) \
- /* These are only called from FGC and */ \
- /* can be removed when we use ignition */ \
- /* only */ \
- V(LoadGlobalICTrampoline)
+ V(GrowArrayElements)
// List of code stubs only used on ARM 32 bits platforms.
#if V8_TARGET_ARCH_ARM
@@ -1632,29 +1627,6 @@ class StringCharAtGenerator {
DISALLOW_COPY_AND_ASSIGN(StringCharAtGenerator);
};
-class LoadGlobalICTrampolineStub : public TurboFanCodeStub {
- public:
- explicit LoadGlobalICTrampolineStub(Isolate* isolate,
- const LoadGlobalICState& state)
- : TurboFanCodeStub(isolate) {
- minor_key_ = state.GetExtraICState();
- }
-
- Code::Kind GetCodeKind() const override { return Code::LOAD_GLOBAL_IC; }
-
- TypeofMode typeof_mode() const {
- LoadGlobalICState state(GetExtraICState());
- return state.typeof_mode();
- }
-
- ExtraICState GetExtraICState() const final {
- return static_cast<ExtraICState>(minor_key_);
- }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadGlobal);
- DEFINE_TURBOFAN_CODE_STUB(LoadGlobalICTrampoline, TurboFanCodeStub);
-};
-
class CallICTrampolineStub : public PlatformCodeStub {
public:
CallICTrampolineStub(Isolate* isolate, const CallICState& state)
@@ -1701,28 +1673,6 @@ class LoadICProtoArrayStub : public TurboFanCodeStub {
DEFINE_TURBOFAN_CODE_STUB(LoadICProtoArray, TurboFanCodeStub);
};
-class LoadGlobalICStub : public TurboFanCodeStub {
- public:
- explicit LoadGlobalICStub(Isolate* isolate, const LoadGlobalICState& state)
- : TurboFanCodeStub(isolate) {
- minor_key_ = state.GetExtraICState();
- }
-
- Code::Kind GetCodeKind() const override { return Code::LOAD_GLOBAL_IC; }
-
- TypeofMode typeof_mode() const {
- LoadGlobalICState state(GetExtraICState());
- return state.typeof_mode();
- }
-
- ExtraICState GetExtraICState() const final {
- return static_cast<ExtraICState>(minor_key_);
- }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadGlobalWithVector);
- DEFINE_TURBOFAN_CODE_STUB(LoadGlobalIC, TurboFanCodeStub);
-};
-
class DoubleToIStub : public PlatformCodeStub {
public:
DoubleToIStub(Isolate* isolate, Register source, Register destination,
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698