Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2608883002: [builtins] Move several CodeStub-based ICs to builtins (Closed)

Created:
3 years, 11 months ago by mvstanton
Modified:
3 years, 11 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com, Yang, danno
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Move several CodeStub-based ICs to builtins This CL is from danno@chromium.org. Moves code stubs LoadIC KeyedLoadICTF StoreIC KeyedStoreICTF LoadICTrampoline KeyedLoadICTrampolineTF StoreICTrampoline KeyedStoreICTrampolineTF into builtins. TBR Yang for serializer changes. R=epertoso@chromium.org TBR=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2608883002 Cr-Commit-Position: refs/heads/master@{#42001} Committed: https://chromium.googlesource.com/v8/v8/+/92d8d955751cf94959d145b1fd3dad2ac97a0185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -194 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +18 lines, -0 lines 0 comments Download
A src/builtins/builtins-ic.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M src/builtins/builtins-utils.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/code-factory.cc View 4 chunks +23 lines, -16 lines 0 comments Download
M src/code-stubs.h View 6 chunks +1 line, -118 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M src/ic/accessor-assembler.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M src/snapshot/code-serializer.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
mvstanton
Hi Enrico, Here is the move of ICs to builtins to support more concurrent compilation ...
3 years, 11 months ago (2016-12-30 10:02:48 UTC) #4
epertoso
lgtm
3 years, 11 months ago (2016-12-30 10:11:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608883002/1
3 years, 11 months ago (2016-12-30 10:13:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/31462)
3 years, 11 months ago (2016-12-30 10:16:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608883002/1
3 years, 11 months ago (2016-12-30 10:22:03 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2016-12-30 10:31:07 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/92d8d955751cf94959d145b1fd3dad2ac97...

Powered by Google App Engine
This is Rietveld 408576698