Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: src/code-stubs.h

Issue 2608883002: [builtins] Move several CodeStub-based ICs to builtins (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index f23aaac4839a0f536ef3cd5bfdb27515ee0eb813..a717f4c749a5cd1284aac93c3c75b4e68348a629 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -103,13 +103,9 @@ class Node;
V(NumberToString) \
V(StringAdd) \
V(GetProperty) \
- V(LoadIC) \
V(LoadICProtoArray) \
- V(KeyedLoadICTF) \
V(StoreFastElement) \
V(StoreGlobal) \
- V(StoreIC) \
- V(KeyedStoreICTF) \
V(StoreInterceptor) \
V(LoadApiGetter) \
V(LoadIndexedInterceptor) \
@@ -118,11 +114,7 @@ class Node;
/* These are only called from FGC and */ \
/* can be removed when we use ignition */ \
/* only */ \
- V(LoadICTrampoline) \
- V(LoadGlobalICTrampoline) \
- V(KeyedLoadICTrampolineTF) \
- V(StoreICTrampoline) \
- V(KeyedStoreICTrampolineTF)
+ V(LoadGlobalICTrampoline)
// List of code stubs only used on ARM 32 bits platforms.
#if V8_TARGET_ARCH_ARM
@@ -1640,17 +1632,6 @@ class StringCharAtGenerator {
DISALLOW_COPY_AND_ASSIGN(StringCharAtGenerator);
};
-
-class LoadICTrampolineStub : public TurboFanCodeStub {
- public:
- explicit LoadICTrampolineStub(Isolate* isolate) : TurboFanCodeStub(isolate) {}
-
- Code::Kind GetCodeKind() const override { return Code::LOAD_IC; }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(Load);
- DEFINE_TURBOFAN_CODE_STUB(LoadICTrampoline, TurboFanCodeStub);
-};
-
class LoadGlobalICTrampolineStub : public TurboFanCodeStub {
public:
explicit LoadGlobalICTrampolineStub(Isolate* isolate,
@@ -1674,50 +1655,6 @@ class LoadGlobalICTrampolineStub : public TurboFanCodeStub {
DEFINE_TURBOFAN_CODE_STUB(LoadGlobalICTrampoline, TurboFanCodeStub);
};
-class KeyedLoadICTrampolineTFStub : public LoadICTrampolineStub {
- public:
- explicit KeyedLoadICTrampolineTFStub(Isolate* isolate)
- : LoadICTrampolineStub(isolate) {}
-
- Code::Kind GetCodeKind() const override { return Code::KEYED_LOAD_IC; }
-
- DEFINE_TURBOFAN_CODE_STUB(KeyedLoadICTrampolineTF, LoadICTrampolineStub);
-};
-
-class StoreICTrampolineStub : public TurboFanCodeStub {
- public:
- StoreICTrampolineStub(Isolate* isolate, const StoreICState& state)
- : TurboFanCodeStub(isolate) {
- minor_key_ = state.GetExtraICState();
- }
-
- Code::Kind GetCodeKind() const override { return Code::STORE_IC; }
-
- ExtraICState GetExtraICState() const final {
- return static_cast<ExtraICState>(minor_key_);
- }
-
- protected:
- StoreICState state() const { return StoreICState(GetExtraICState()); }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(Store);
- DEFINE_TURBOFAN_CODE_STUB(StoreICTrampoline, TurboFanCodeStub);
-};
-
-class KeyedStoreICTrampolineTFStub : public StoreICTrampolineStub {
- public:
- KeyedStoreICTrampolineTFStub(Isolate* isolate, const StoreICState& state)
- : StoreICTrampolineStub(isolate, state) {}
-
- Code::Kind GetCodeKind() const override { return Code::KEYED_STORE_IC; }
-
- LanguageMode language_mode() const {
- return StoreICState(GetExtraICState()).language_mode();
- }
-
- DEFINE_TURBOFAN_CODE_STUB(KeyedStoreICTrampolineTF, StoreICTrampolineStub);
-};
-
class CallICTrampolineStub : public PlatformCodeStub {
public:
CallICTrampolineStub(Isolate* isolate, const CallICState& state)
@@ -1740,16 +1677,6 @@ class CallICTrampolineStub : public PlatformCodeStub {
DEFINE_PLATFORM_CODE_STUB(CallICTrampoline, PlatformCodeStub);
};
-class LoadICStub : public TurboFanCodeStub {
- public:
- explicit LoadICStub(Isolate* isolate) : TurboFanCodeStub(isolate) {}
-
- Code::Kind GetCodeKind() const override { return Code::LOAD_IC; }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadWithVector);
- DEFINE_TURBOFAN_CODE_STUB(LoadIC, TurboFanCodeStub);
-};
-
class LoadICProtoArrayStub : public TurboFanCodeStub {
public:
explicit LoadICProtoArrayStub(Isolate* isolate,
@@ -1796,50 +1723,6 @@ class LoadGlobalICStub : public TurboFanCodeStub {
DEFINE_TURBOFAN_CODE_STUB(LoadGlobalIC, TurboFanCodeStub);
};
-class KeyedLoadICTFStub : public LoadICStub {
- public:
- explicit KeyedLoadICTFStub(Isolate* isolate) : LoadICStub(isolate) {}
-
- Code::Kind GetCodeKind() const override { return Code::KEYED_LOAD_IC; }
-
- DEFINE_TURBOFAN_CODE_STUB(KeyedLoadICTF, LoadICStub);
-};
-
-class StoreICStub : public TurboFanCodeStub {
- public:
- StoreICStub(Isolate* isolate, const StoreICState& state)
- : TurboFanCodeStub(isolate) {
- minor_key_ = state.GetExtraICState();
- }
-
- Code::Kind GetCodeKind() const override { return Code::STORE_IC; }
-
- LanguageMode language_mode() const {
- return StoreICState(GetExtraICState()).language_mode();
- }
-
- ExtraICState GetExtraICState() const final {
- return static_cast<ExtraICState>(minor_key_);
- }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(StoreWithVector);
- DEFINE_TURBOFAN_CODE_STUB(StoreIC, TurboFanCodeStub);
-};
-
-class KeyedStoreICTFStub : public StoreICStub {
- public:
- KeyedStoreICTFStub(Isolate* isolate, const StoreICState& state)
- : StoreICStub(isolate, state) {}
-
- Code::Kind GetCodeKind() const override { return Code::KEYED_STORE_IC; }
-
- LanguageMode language_mode() const {
- return StoreICState(GetExtraICState()).language_mode();
- }
-
- DEFINE_TURBOFAN_CODE_STUB(KeyedStoreICTF, StoreICStub);
-};
-
class DoubleToIStub : public PlatformCodeStub {
public:
DoubleToIStub(Isolate* isolate, Register source, Register destination,
« no previous file with comments | « src/code-factory.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698