Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2251)

Unified Diff: appengine/findit/handlers/flake/check_flake.py

Issue 2608853002: [Findit] Adding suspected CL to master flake analysis in preparation for try jobs (Closed)
Patch Set: Addressing comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/handlers/flake/test/check_flake_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/flake/check_flake.py
diff --git a/appengine/findit/handlers/flake/check_flake.py b/appengine/findit/handlers/flake/check_flake.py
index b6334e55cf69db14fa7d50486dfe816c18dd18a8..aab0dc2509591c886d08f8fa75ea980c6159a174 100644
--- a/appengine/findit/handlers/flake/check_flake.py
+++ b/appengine/findit/handlers/flake/check_flake.py
@@ -19,14 +19,6 @@ from waterfall.flake import flake_analysis_service
from waterfall.flake import triggering_sources
-def _FindSuspectedFlakeBuildDataPoint(analysis):
- for data_point in analysis.data_points:
- if data_point.build_number == analysis.suspected_flake_build_number:
- return data_point
-
- return None
-
-
def _GetSuspectedFlakeInfo(analysis):
"""Returns a dict with information about the suspected flake build.
@@ -48,7 +40,7 @@ def _GetSuspectedFlakeInfo(analysis):
if analysis.suspected_flake_build_number is None:
return {}
- data_point = _FindSuspectedFlakeBuildDataPoint(analysis)
+ data_point = analysis.GetDataPointOfSuspectedBuild()
assert data_point
return {
« no previous file with comments | « no previous file | appengine/findit/handlers/flake/test/check_flake_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698