Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: appengine/findit/handlers/flake/test/check_flake_test.py

Issue 2608853002: [Findit] Adding suspected CL to master flake analysis in preparation for try jobs (Closed)
Patch Set: Addressing comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/handlers/flake/check_flake.py ('k') | appengine/findit/model/flake/flake_culprit.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/flake/test/check_flake_test.py
diff --git a/appengine/findit/handlers/flake/test/check_flake_test.py b/appengine/findit/handlers/flake/test/check_flake_test.py
index 87ac4ab03cbfe8938d9cc54a3a52d121c0993a2e..d7d0f85ff829016f64e842090a0d0656e5e469cb 100644
--- a/appengine/findit/handlers/flake/test/check_flake_test.py
+++ b/appengine/findit/handlers/flake/test/check_flake_test.py
@@ -395,47 +395,3 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
self.assertEqual([[2, success_rate, None, build_number, 'git_hash_2', 1,
'git_hash_1']],
check_flake._GetCoordinatesData(analysis))
-
- def testFindSuspectedFlakeBuildDataPoint(self):
- master_name = 'm'
- builder_name = 'b'
- build_number = 123
- step_name = 's'
- test_name = 't'
- analysis = MasterFlakeAnalysis.Create(
- master_name, builder_name, build_number, step_name, test_name)
- analysis.suspected_flake_build_number = build_number
- data_point_1 = DataPoint()
- data_point_1.build_number = build_number - 1
- data_point_1.pass_rate = 1
- data_point_1.commit_position = 2
- data_point_1.git_hash = 'git_hash_2'
- data_point_1.previous_build_commit_position = 1
- data_point_1.previous_build_git_hash = 'git_hash_1'
- analysis.data_points.append(data_point_1)
- data_point_2 = DataPoint()
- data_point_2.build_number = build_number
- data_point_2.pass_rate = 0.9
- data_point_2.commit_position = 4
- data_point_2.git_hash = 'git_hash_4'
- data_point_2.previous_build_commit_position = 3
- data_point_2.previous_build_git_hash = 'git_hash_3'
- analysis.data_points.append(data_point_2)
- analysis.Save()
-
- self.assertEqual(data_point_2,
- check_flake._FindSuspectedFlakeBuildDataPoint(analysis))
-
- def testFindSuspectedFlakeBuildDataPointNotFound(self):
- master_name = 'm'
- builder_name = 'b'
- build_number = 123
- step_name = 's'
- test_name = 't'
- analysis = MasterFlakeAnalysis.Create(
- master_name, builder_name, build_number, step_name, test_name)
- analysis.suspected_flake_build_number = build_number
- analysis.data_points = []
- analysis.Save()
-
- self.assertIsNone(check_flake._FindSuspectedFlakeBuildDataPoint(analysis))
« no previous file with comments | « appengine/findit/handlers/flake/check_flake.py ('k') | appengine/findit/model/flake/flake_culprit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698