[Findit] Adding suspected CL to master flake analysis in preparation for try jobs

appengine/findit/handlers/flake/check_flake.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from google.appengine.api import users
 from google.appengine.ext import ndb
 
 from common.base_handler import BaseHandler
 from common.base_handler import Permission
 from gae_libs.http import auth_util
 from libs import time_util
 from model import analysis_status
 from model import triage_status
 from model.flake.flake_analysis_request import FlakeAnalysisRequest
 from model.flake.master_flake_analysis import MasterFlakeAnalysis
 from waterfall.flake import flake_analysis_service
 from waterfall.flake import triggering_sources
 
 
-def _FindSuspectedFlakeBuildDataPoint(analysis):
-  for data_point in analysis.data_points:
-    if data_point.build_number == analysis.suspected_flake_build_number:
-      return data_point
-
-  return None
-
-
 def _GetSuspectedFlakeInfo(analysis):
   """Returns a dict with information about the suspected flake build.
 
   Args:
     analysis (MasterFlakeAnalysis): The master flake analysis the suspected
       flake build is associated with.
 
   Returns:
     A dict in the format:
       {
           'build_number': int,
           'commit_position': int,
           'git_hash': str,
           'previous_build_commit_position': int,
           'previous_build_git_hash': str,
           'triage_result': int (correct, incorrect, etc.)
       }
   """
   if analysis.suspected_flake_build_number is None:
     return {}
 
-  data_point = _FindSuspectedFlakeBuildDataPoint(analysis)
+  data_point = analysis.GetDataPointOfSuspectedBuild()
   assert data_point
 
   return {
       'build_number': analysis.suspected_flake_build_number,
       'commit_position': data_point.commit_position,
       'git_hash': data_point.git_hash,
       'previous_build_commit_position': (
           data_point.previous_build_commit_position),
       'previous_build_git_hash': data_point.previous_build_git_hash,
       'triage_result': (
@@ skipping 171 matching lines @@
       data['duration'] = time_util.FormatDuration(
           analysis.start_time,
           analysis.end_time or time_util.GetUTCNow())
 
     data['pass_rates'] = _GetCoordinatesData(analysis)
 
     return {
         'template': 'flake/result.html',
         'data': data
     }