Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2608823002: Move blink::serializedCharacterData array to read-only data segment (Closed)

Created:
3 years, 11 months ago by brucedawson
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move blink::serializedCharacterData array to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves 11,844 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 Committed: https://crrev.com/eafbd71d2e7eda209965d66a540d596038edd68c Cr-Commit-Position: refs/heads/master@{#441083}

Patch Set 1 #

Patch Set 2 : Might as well mark serializedCharacterDataSize as const also #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/text/Character.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/CharacterPropertyDataGenerator.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
brucedawson
PTAL
3 years, 11 months ago (2016-12-29 23:38:12 UTC) #12
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-02 07:48:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608823002/20001
3 years, 11 months ago (2017-01-02 23:22:16 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 01:16:39 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 01:18:58 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eafbd71d2e7eda209965d66a540d596038edd68c
Cr-Commit-Position: refs/heads/master@{#441083}

Powered by Google App Engine
This is Rietveld 408576698