|
|
Created:
3 years, 11 months ago by brucedawson Modified:
3 years, 11 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
blink-reviews, chromium-reviews, kinuko+watch Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove blink::serializedCharacterData array to read-only data segment
This array is logically const but was not marked as such. Marking it as
const lets the compiler/linker store it in the read-only data segment,
which is strictly better than being in read/write memory. This change
moves 11,844 bytes from the .data to .rdata segment.
Note that "const" implies static which is why "extern const" is needed.
BUG=677351
Committed: https://crrev.com/eafbd71d2e7eda209965d66a540d596038edd68c
Cr-Commit-Position: refs/heads/master@{#441083}
Patch Set 1 #Patch Set 2 : Might as well mark serializedCharacterDataSize as const also #
Messages
Total messages: 22 (17 generated)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Move blink::serializedCharacterData arrays to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves about 11,800 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 ========== to ========== Move blink::serializedCharacterData arrays to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves about 11,800 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 ==========
brucedawson@chromium.org changed reviewers: + jochen@chromium.org
Description was changed from ========== Move blink::serializedCharacterData arrays to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves about 11,800 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 ========== to ========== Move blink::serializedCharacterData arrays to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves 11,840 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 ==========
Description was changed from ========== Move blink::serializedCharacterData arrays to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves 11,840 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 ========== to ========== Move blink::serializedCharacterData array to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves 11,840 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Move blink::serializedCharacterData array to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves 11,840 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 ========== to ========== Move blink::serializedCharacterData array to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves 11,844 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 ==========
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483399325393470, "parent_rev": "b4c6ec9a0bd0258f0c3b392de0e92940df687e2c", "commit_rev": "b3e6178942726ebcf6fa595bf3019c9068772877"}
Message was sent while issue was closed.
Description was changed from ========== Move blink::serializedCharacterData array to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves 11,844 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 ========== to ========== Move blink::serializedCharacterData array to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves 11,844 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 Review-Url: https://codereview.chromium.org/2608823002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Move blink::serializedCharacterData array to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves 11,844 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 Review-Url: https://codereview.chromium.org/2608823002 ========== to ========== Move blink::serializedCharacterData array to read-only data segment This array is logically const but was not marked as such. Marking it as const lets the compiler/linker store it in the read-only data segment, which is strictly better than being in read/write memory. This change moves 11,844 bytes from the .data to .rdata segment. Note that "const" implies static which is why "extern const" is needed. BUG=677351 Committed: https://crrev.com/eafbd71d2e7eda209965d66a540d596038edd68c Cr-Commit-Position: refs/heads/master@{#441083} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/eafbd71d2e7eda209965d66a540d596038edd68c Cr-Commit-Position: refs/heads/master@{#441083} |