third_party/WebKit/Source/platform/text/CharacterPropertyDataGenerator.cpp - Issue 2608823002: Move blink::serializedCharacterData array to read-only data segment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/CharacterPropertyDataGenerator.cpp

Issue 2608823002: Move blink::serializedCharacterData array to read-only data segment (Closed)

Patch Set: Might as well mark serializedCharacterDataSize as const also Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/text/CharacterPropertyDataGenerator.cpp

diff --git a/third_party/WebKit/Source/platform/text/CharacterPropertyDataGenerator.cpp b/third_party/WebKit/Source/platform/text/CharacterPropertyDataGenerator.cpp

index 45cad2f2457a9baa0885f7b1faf2189cb72f80a6..57d6358805524d39c85839fd66d1c00b2e2fd3f0 100644

--- a/third_party/WebKit/Source/platform/text/CharacterPropertyDataGenerator.cpp

+++ b/third_party/WebKit/Source/platform/text/CharacterPropertyDataGenerator.cpp

@@ -54,8 +54,8 @@ static void generateUTrieSerialized(FILE* fp, int32_t size, uint8_t* array) {

fprintf(fp,

"#include <cstdint>\n\n"

"namespace blink {\n\n"

- "int32_t serializedCharacterDataSize = %d;\n"

- "uint8_t serializedCharacterData[] = {",

+ "extern const int32_t serializedCharacterDataSize = %d;\n"

+ "extern const uint8_t serializedCharacterData[] = {",

size);

for (int32_t i = 0; i < size;) {

fprintf(fp, "\n ");

« no previous file with comments | « third_party/WebKit/Source/platform/text/Character.cpp ('k') | no next file » | no next file with comments »