Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2608733004: MD Settings: Downloads directory should be relative to Downloads directory. (Closed)

Created:
3 years, 11 months ago by xdai1
Modified:
3 years, 11 months ago
Reviewers:
stevenjb, Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Downloads directory should be relative to Downloads directory. BUG=637371 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/220a249a750cb6c3f38015d61d249bc06fea7538 Cr-Commit-Position: refs/heads/master@{#440998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M chrome/browser/resources/settings/downloads_page/downloads_page.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/downloads_page/downloads_page.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
xdai1
stevenjb@, could you help review this CL please? Thanks!
3 years, 11 months ago (2016-12-29 21:25:46 UTC) #3
stevenjb
Thanks for the quick fix, lgtm!
3 years, 11 months ago (2016-12-29 21:33:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608733004/1
3 years, 11 months ago (2016-12-29 21:37:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 22:45:30 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/220a249a750cb6c3f38015d61d249bc06fea7538 Cr-Commit-Position: refs/heads/master@{#440998}
3 years, 11 months ago (2017-01-02 15:53:31 UTC) #11
Dan Beam
this is not desired on all platforms, afaik, please make this ChromeOS-only or revert
3 years, 11 months ago (2017-01-04 19:31:56 UTC) #13
xdai1
On 2017/01/04 19:31:56, Dan Beam wrote: > this is not desired on all platforms, afaik, ...
3 years, 11 months ago (2017-01-04 20:23:29 UTC) #14
Dan Beam
3 years, 11 months ago (2017-01-04 21:54:40 UTC) #15
Message was sent while issue was closed.
On 2017/01/04 20:23:29, xdai1 wrote:
> On 2017/01/04 19:31:56, Dan Beam wrote:
> > this is not desired on all platforms, afaik, please make this ChromeOS-only
or
> > revert
> 
> Oh sorry. Will work on a quick fix today.

https://codereview.chromium.org/2616713002

Powered by Google App Engine
This is Rietveld 408576698